2002-01-09 09:06:51

by Nathan Myers

[permalink] [raw]
Subject: bad patch in aic7xxx_linux.c

Marcelo,

In patch-2.4.17-pre2, a nonsensical change was made in
linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
harmless, it suggests to me that you had intended to fold in an
entirely different patch, and "missed".

I don't find a current maintainer for aic7xxx listed in MAINTAINERS.

Nathan Myers
ncm at cantrip dot org


2002-01-09 09:22:01

by David Miller

[permalink] [raw]
Subject: Re: bad patch in aic7xxx_linux.c

From: Nathan Myers <[email protected]>
Date: Wed, 9 Jan 2002 09:06:28 +0000

In patch-2.4.17-pre2, a nonsensical change was made in
linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
harmless, it suggests to me that you had intended to fold in an
entirely different patch, and "missed".

Missed? That patch fixes a lethal bug.

I don't find a current maintainer for aic7xxx listed in MAINTAINERS.

It's listed in the aic7xxx sources, but the fix in question came to
Marcelo via Jens Axboe.

Franks a lot,
David S. Miller
[email protected]

2002-01-09 17:36:36

by Marcelo Tosatti

[permalink] [raw]
Subject: Re: bad patch in aic7xxx_linux.c



On Wed, 9 Jan 2002, Nathan Myers wrote:

> Marcelo,
>
> In patch-2.4.17-pre2, a nonsensical change was made in
> linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
> harmless, it suggests to me that you had intended to fold in an
> entirely different patch, and "missed".
>
> I don't find a current maintainer for aic7xxx listed in MAINTAINERS.

Its not nonsensical: It fixes a critical bug as David pointed out.


2002-01-10 07:43:08

by Nathan Myers

[permalink] [raw]
Subject: Re: bad patch in aic7xxx_linux.c

On Wed, Jan 09, 2002 at 01:20:46AM -0800, David S. Miller wrote:
> From: Nathan Myers <[email protected]>
>> In patch-2.4.18-pre2, a nonsensical change was made in
>> linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
>> harmless, it suggests to me that you had intended to fold in an
>> entirely different patch, and "missed".
>
> Missed? That patch fixes a lethal bug.

Indeed, I missed that the value was also passed to ahc_linux_map_seg()
before being clobbered in the next statement.

> I don't find a current maintainer for aic7xxx listed in MAINTAINERS.
>
> It's listed in the aic7xxx sources, but the fix in question came to
> Marcelo via Jens Axboe.

One can guess, but there are no addresses for anyone noted there later
than 1999. In particular, Justin's address isn't listed.

I am interested in hotplugged aic7xxx (1480 CardBus). I will be posting
an Oops shortly related to that, unless somebody tells me not to bother.

Nathan Myers
ncm at cantrip dot org

2002-01-10 17:59:48

by Justin T. Gibbs

[permalink] [raw]
Subject: Re: bad patch in aic7xxx_linux.c

>One can guess, but there are no addresses for anyone noted there later
>than 1999. In particular, Justin's address isn't listed.

I monitor this list. A Yahoo search using my name provides several
hits for my email address.

>I am interested in hotplugged aic7xxx (1480 CardBus). I will be posting
>an Oops shortly related to that, unless somebody tells me not to bother.

Feel free to send me the oops.

--
Justin

2002-01-11 02:25:41

by David Miller

[permalink] [raw]
Subject: Re: bad patch in aic7xxx_linux.c

From: "Justin T. Gibbs" <[email protected]>
Date: Thu, 10 Jan 2002 10:59:16 -0700

>One can guess, but there are no addresses for anyone noted there later
>than 1999. In particular, Justin's address isn't listed.

I monitor this list. A Yahoo search using my name provides several
hits for my email address.

Your contact information really ought to be up to date in
the sources and linux/MAINTAINERS