2002-01-23 07:35:28

by Miles Lane

Subject: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return

make[2]: Entering directory `/usr/src/linux/drivers/net'
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DEXPORT_SYMTAB -c aironet4500_core.c
aironet4500_core.c: In function `awc_init':
aironet4500_core.c:2839: incompatible types in return
aironet4500_core.c:2841: warning: control reaches end of non-void function
make[2]: *** [aironet4500_core.o] Error 1

CONFIG_NET_PCMCIA=y
CONFIG_PCMCIA_3C589=m
CONFIG_PCMCIA_3C574=m
CONFIG_PCMCIA_FMVJ18X=m
CONFIG_PCMCIA_PCNET=y
CONFIG_PCMCIA_NMCLAN=m
CONFIG_PCMCIA_SMC91C92=m
CONFIG_PCMCIA_XIRC2PS=m
CONFIG_PCMCIA_AXNET=m
CONFIG_PCMCIA_XIRCOM=m
CONFIG_PCMCIA_XIRTULIP=m
CONFIG_NET_PCMCIA_RADIO=y
CONFIG_PCMCIA_RAYCS=y
CONFIG_AIRONET4500_CS=m

2002-01-23 07:46:28

by Evgeniy Polyakov

Subject: Re: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return

On 22 Jan 2002 23:34:08 -0800
Miles Lane <[email protected]> wrote:

>
> make[2]: Entering directory `/usr/src/linux/drivers/net'
> gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE
> -DEXPORT_SYMTAB -c aironet4500_core.c aironet4500_core.c: In function
> `awc_init': aironet4500_core.c:2839: incompatible types in return
> aironet4500_core.c:2841: warning: control reaches end of non-void
> function make[2]: *** [aironet4500_core.o] Error 1

Try this patch, but it is given WITHOUT ANY WARRANTY.
I even cann't test to compile it.
And there is not ieee card here.
So, it was wrote with luck and common sense.
I hope it will help you.

P.S. If this is full bullshit... then i apologize and go learning Linux
kernel again...

--- ./drivers/net/aironet4500_core.c~ Sun Sep 30 23:26:06 2001
+++ ./drivers/net/aironet4500_core.c Wed Jan 23 10:44:03 2002
@@ -2836,7 +2836,7 @@
return 0;
final:
printk(KERN_ERR "aironet init failed \n");
- return NODEV;
+ return -1;

};


Evgeniy Polyakov ( s0mbre ).

2002-01-23 13:01:05

by Dave Jones

Subject: Re: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return

On Wed, Jan 23, 2002 at 10:45:50AM +0300, Evgeniy Polyakov wrote:
> --- ./drivers/net/aironet4500_core.c~ Sun Sep 30 23:26:06 2001
> +++ ./drivers/net/aironet4500_core.c Wed Jan 23 10:44:03 2002
> @@ -2836,7 +2836,7 @@
> return 0;
> final:
> printk(KERN_ERR "aironet init failed \n");
> - return NODEV;
> + return -1;

This should probably be return -ENODEV

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs

2002-01-23 18:03:40

by Evgeniy Polyakov

Subject: Re: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return

On Wed, 23 Jan 2002 14:00:44 +0100
Dave Jones <[email protected]> wrote:

> > - return NODEV;
> > + return -1;

> This should probably be return -ENODEV

It sould be negative integer.
kdev_val(NODEV) == 0, so it will indicate successive finish, that is not
right.

> --
> | Dave Jones. http://www.codemonkey.org.uk
> | SuSE Labs

Evgeniy Polyakov ( s0mbre ).

2002-01-25 02:58:02

by Evgeniy Polyakov

Subject: Re: 2.5.3-pre3 -- aironet4500_core.c:2839: In function `awc_init': incompatible types in return

On Wed, 23 Jan 2002 21:02:46 +0300
Evgeniy Polyakov <[email protected]> wrote:

> > > - return NODEV;
> > > + return -1;
>
> > This should probably be return -ENODEV
>
> It sould be negative integer.
> kdev_val(NODEV) == 0, so it will indicate successive finish, that is not
> right.

Ooops, sorry, this <censored> was written probably on drugs...
You absolutely right, and i didn't see 'E' letter in your mail.
Take my appologize.

> > --
> > | Dave Jones. http://www.codemonkey.org.uk
> > | SuSE Labs

Evgeniy Polyakov ( s0mbre ).