2002-02-09 01:10:41

by Skip Ford

[permalink] [raw]
Subject: de_put: entry sys already free!

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Just an FYI, I've received this syslog message twice now with
2.5.4-pre3: 'de_put: entry sys already free!'.

It seems to be harmless, but I'd thought I'd post it. It's just a
procfs error message, but maybe somebody out there has a clue why it's
being generated (aside from what the message says).

It's coming from de_put in fs/proc/inode.c

- --
Skip ID: 0x7EDDDB0A
-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAjxkdjQACgkQBMKxVH7d2wpvFQCeLAKzhOflfnbjsB/LYXp2nE2D
Tk0AoNA5/BXNPzrMdUW2n5dCCLqUmnu3
=7U11
-----END PGP SIGNATURE-----


2002-02-09 01:31:09

by Alexander Viro

[permalink] [raw]
Subject: Re: de_put: entry sys already free!



On Fri, 8 Feb 2002, Skip Ford wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Just an FYI, I've received this syslog message twice now with
> 2.5.4-pre3: 'de_put: entry sys already free!'.
>
> It seems to be harmless, but I'd thought I'd post it. It's just a
> procfs error message, but maybe somebody out there has a clue why it's
> being generated (aside from what the message says).

Fix already merged and no, it's not quite harmless.

--- fs/proc/base.c Thu Feb 7 19:25:52 2002
+++ /tmp/base.c Fri Feb 8 18:36:41 2002
@@ -1003,8 +1003,7 @@
ei = PROC_I(inode);
inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
inode->i_ino = fake_ino(0, PROC_PID_INO);
- ei->file = NULL;
- ei->task = NULL;
+ ei->pde = NULL;
inode->i_mode = S_IFLNK|S_IRWXUGO;
inode->i_uid = inode->i_gid = 0;
inode->i_size = 64;

2002-02-09 01:42:10

by Skip Ford

[permalink] [raw]
Subject: Re: de_put: entry sys already free!

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Viro wrote:
>
> Fix already merged and no, it's not quite harmless.

Thanks for the patch...and how do I fix any damage it caused if it's not
harmless? It sure didn't seem to cause any.

- --
Skip ID: 0x7EDDDB0A
-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAjxkfcYACgkQBMKxVH7d2wqQEgCg6hj/nUXB92aylwKCpg41w7Wt
XAIAoLkykjmxn6a32cC9pMSYuHBNkCJA
=O2cd
-----END PGP SIGNATURE-----

2002-02-09 01:46:43

by Alexander Viro

[permalink] [raw]
Subject: Re: de_put: entry sys already free!



On Fri, 8 Feb 2002, Skip Ford wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Alexander Viro wrote:
> >
> > Fix already merged and no, it's not quite harmless.
>
> Thanks for the patch...and how do I fix any damage it caused if it's not
> harmless? It sure didn't seem to cause any.

In principle - memory corruption is possible.