2002-02-18 22:25:18

by Krzysztof Rusocki

[permalink] [raw]
Subject: [PATCH] Make IP-Config work without ip= supplied


Hi,

Just noticed that IP-Config behavior when no ip= parm is used has changed in
2.2.18.

Up to 2.2.17 IP-Config was enabled even when ip= was omitted. I think that
it's good for use in i.e. diskless nodes.

Since 2.2.18, IP-Config does nothing at all until ip= is passed to the
kernel, however Documentation/nfsroot.txt still says that IP-Config is
enabled by default. Was that intentional change?

Such behavior remains in both 2.2.20 and 2.4.18-rc1. Following patches
(against these two kernel trees) make IP-Config enabled by default.

Cheers,
Krzysztof

PS
please CC, not a subscriber.

PS2
this was also sent to linux-net but got spamfiltered, i suppose
(checked on marc.theaimsgroup.com)


Attachments:
(No filename) (697.00 B)
ipconfig.c.diff-2.4.18-rc1 (393.00 B)
ipconfig.c.diff-2.2.20 (353.00 B)
Download all attachments

2002-02-18 22:34:58

by H. Peter Anvin

[permalink] [raw]
Subject: Re: [PATCH] Make IP-Config work without ip= supplied

Followup to: <[email protected]>
By author: Krzysztof Rusocki <[email protected]>
In newsgroup: linux.dev.kernel
>
> Hi,
>
> Just noticed that IP-Config behavior when no ip= parm is used has changed in
> 2.2.18.
>
> Up to 2.2.17 IP-Config was enabled even when ip= was omitted. I think that
> it's good for use in i.e. diskless nodes.
>
> Since 2.2.18, IP-Config does nothing at all until ip= is passed to the
> kernel, however Documentation/nfsroot.txt still says that IP-Config is
> enabled by default. Was that intentional change?
>
> Such behavior remains in both 2.2.20 and 2.4.18-rc1. Following patches
> (against these two kernel trees) make IP-Config enabled by default.
>

I don't think this is a good idea. The current behaviour should work
across the board. Diskless nodes should use a diskless bootloader
which support command lines -- that way you get to specify the mode as
well. *ALL* nodes should use the command line these days.

Can we get rid of the g----d bootsect.S, please?

-hpa
--
<[email protected]> at work, <[email protected]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt <[email protected]>