2002-02-19 20:21:53

by Pavel Machek

[permalink] [raw]
Subject: Tiny IDE cleanup

Hi!

What about this tiny cleanup? Its against 2.4., but applicable to 2.5,
too.

Pavel

--- clean.2.4/include/linux/ide.h Mon Nov 5 21:43:28 2001
+++ linux-swsusp.24/include/linux/ide.h Tue Feb 19 20:38:38 2002
@@ -697,11 +698,9 @@
* structure directly (the allocation/layout may change!).
*
*/
-#ifndef _IDE_C
extern ide_hwif_t ide_hwifs[]; /* master data repository */
extern ide_module_t *ide_modules;
extern ide_module_t *ide_probe;
-#endif
extern int noautodma;

/*
@@ -900,10 +899,8 @@
void do_ide_request (request_queue_t * q);
void ide_init_subdrivers (void);

-#ifndef _IDE_C
extern struct block_device_operations ide_fops[];
extern ide_proc_entry_t generic_subdriver_entries[];
-#endif

#ifdef _IDE_C
#ifdef CONFIG_BLK_DEV_IDE

--
(about SSSCA) "I don't say this lightly. However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa


2002-02-20 10:29:05

by Martin Dalecki

[permalink] [raw]
Subject: Re: Tiny IDE cleanup

Pavel Machek wrote:
> Hi!
>
> What about this tiny cleanup? Its against 2.4., but applicable to 2.5,
> too.
>

That's file.

If you dare to have a look at the LOCAL_END_REQUEST macro
as well? It's only used by IDE and NBD code.
I think that from IDE it can be just deleted. But I didn't
look at NBD.

2002-02-20 10:35:35

by Jens Axboe

[permalink] [raw]
Subject: Re: Tiny IDE cleanup

On Wed, Feb 20 2002, Martin Dalecki wrote:
> Pavel Machek wrote:
> >Hi!
> >
> >What about this tiny cleanup? Its against 2.4., but applicable to 2.5,
> >too.
> >
>
> That's file.
>
> If you dare to have a look at the LOCAL_END_REQUEST macro
> as well? It's only used by IDE and NBD code.
> I think that from IDE it can be just deleted. But I didn't
> look at NBD.

LOCAL_END_REQUEST is safe to kill, please go ahead.

--
Jens Axboe