2002-02-28 23:43:06

by Chris Leech

[permalink] [raw]
Subject: RE: hardware VLAN acceleration


> Any time VLAN groups exist, the VLAN module should not be unloadable.
>
> This is a hokey area of how the VLAN layer works and I intend
> to fix it.

OK. I was just trying really hard to find potential API problems earlier
rather than later, obviously without taking the time to completely
understand the VLAN layer internals :)

I don't see why it wouldn't be desirable to have a method of stopping the
driver from continuing to call vlan_hwaccel_rx, so that the vlan_group could
be freed after all the VIDs were removed. It could be as simple as
declaring that dev->vlan_rx_register(dev, NULL) is valid.

Chris


2002-03-01 00:01:08

by David Miller

[permalink] [raw]
Subject: Re: hardware VLAN acceleration

From: "Leech, Christopher" <[email protected]>
Date: Thu, 28 Feb 2002 15:38:24 -0800

I don't see why it wouldn't be desirable to have a method of stopping the
driver from continuing to call vlan_hwaccel_rx, so that the vlan_group could
be freed after all the VIDs were removed. It could be as simple as
declaring that dev->vlan_rx_register(dev, NULL) is valid.

This is how I intended it to be used. It isn't done now only because
this event does not occur within the VLAN layer :)