2002-03-09 00:01:26

by jason

Subject: [patch] ide-scsi compile fix

GCC gives an error about an undefined reference to idescsi_init from ide.c when compiling 2.5.6 with ide scsi emulation enabled, this patch corrects the problem.

--- a/drivers/scsi/ide-scsi.c Fri Mar 8 17:22:52 2002
+++ b/drivers/scsi/ide-scsi.c Fri Mar 8 17:23:00 2002
@@ -565,7 +565,7 @@
/*
* idescsi_init will register the driver for each scsi.
*/
-static int idescsi_init(void)
+int idescsi_init(void)
{
ide_drive_t *drive;
idescsi_scsi_t *scsi;

2002-03-09 13:09:31

by Martin Dalecki

Subject: Re: [patch] ide-scsi compile fix

jason wrote:
> GCC gives an error about an undefined reference to idescsi_init from ide.c when compiling 2.5.6 with ide scsi emulation enabled, this patch corrects the problem.

Tank you for looking after this.
That was a bit too far reaching on my behalf. You are right if
one disables module support.

>
> --- a/drivers/scsi/ide-scsi.c Fri Mar 8 17:22:52 2002
> +++ b/drivers/scsi/ide-scsi.c Fri Mar 8 17:23:00 2002
> @@ -565,7 +565,7 @@
> /*
> * idescsi_init will register the driver for each scsi.
> */
> -static int idescsi_init(void)
> +int idescsi_init(void)
> {
> ide_drive_t *drive;
> idescsi_scsi_t *scsi;
>
>

2002-03-11 10:39:43

by Petr Titěra

Subject: Re: [patch] ide-scsi compile fix

Martin Dalecki wrote:
> jason wrote:
>
>> GCC gives an error about an undefined reference to idescsi_init from
>> ide.c when compiling 2.5.6 with ide scsi emulation enabled, this patch
>> corrects the problem.
>
>
> Tank you for looking after this.
> That was a bit too far reaching on my behalf. You are right if
> one disables module support.
>

But ide-scsi works even if you remove call of this function from ide.c Why?

Petr Titera