"Avoid creating multiple /proc entries when (buggy) ACPI
BIOS tables erroneously list both fixed- and generic-
feature buttons."
While the function already prints a disgnostic message
on this and registers the new button dir in /proc, it fails to
remove the old one.
This is a trivial patch which actually does that.
ACPI maintainer Andy, please approve that.
Regards,
Wolly
Patch is against 2.4.18 kernel;
patched file sm_osl.c is in drivers/acpi/ospm/button/
---------------------------<patch>---------------------------
diff -u bn_osl.c bn_osl.c-patched
--- bn_osl.c Mon Mar 11 14:06:56 2002
+++ bn_osl.c-patched Mon Mar 11 14:02:27 2002
@@ -96,6 +96,7 @@
break;
case BN_TYPE_FIXED:
printk(KERN_WARNING "ACPI: Multiple power buttons detected, ignoring fixed-feature\n");
+ remove_proc_entry(BN_PROC_POWER_BUTTON, bn_proc_root);
default:
printk(KERN_INFO "ACPI: Power Button (CM) found\n");
bn_power_button = BN_TYPE_GENERIC;
> From: Wolly [mailto:[email protected]]
> "Avoid creating multiple /proc entries when (buggy) ACPI
> BIOS tables erroneously list both fixed- and generic-
> feature buttons."
> While the function already prints a disgnostic message
> on this and registers the new button dir in /proc, it fails to
> remove the old one.
> Patch is against 2.4.18 kernel;
> patched file sm_osl.c is in drivers/acpi/ospm/button/
Hi Wolly,
ACPI development is happening out of the mainline for now, until it
stabilizes. Please try the latest patches available at
http://sf.net/projects/acpi . AFAIK the button thing is fixed in the latest
ACPI patch, although the sysrq hookup feature is new, so that is definitely
useful code, thanks.
Regards -- Andy