2002-03-11 13:46:03

by Denis Vlasenko

[permalink] [raw]
Subject: [PATCH] KERN_INFO 2.4.19-pre2 devfs

Primary purpose of this patch is to make KERN_WARNING and
KERN_INFO log levels closer to their original meaning.
Today they are quite far from what was intended.
Just look what kernel writes at the WARNING level
each time you boot your box!

Diff for devfs.

diff -u --recursive -x *.orig -x *.rej linux-2.4.19-pre2/fs/devfs/base.c
linux-new/fs/devfs/base.c
--- linux-2.4.19-pre2/fs/devfs/base.c Mon Feb 25 17:38:08 2002
+++ linux-new/fs/devfs/base.c Mon Mar 11 10:26:25 2002
@@ -3463,18 +3463,17 @@
static int __init init_devfs_fs (void)
{
int err;
-
- printk ("%s: v%s Richard Gooch ([email protected])\n",
- DEVFS_NAME, DEVFS_VERSION);
+ printk (KERN_INFO DEVFS_NAME ": v" DEVFS_VERSION
+ " Richard Gooch ([email protected])\n");
devfsd_buf_cache = kmem_cache_create ("devfsd_event",
sizeof (struct devfsd_buf_entry),
0, 0, NULL, NULL);
if (!devfsd_buf_cache) OOPS ("(): unable to allocate event slab\n");
#ifdef CONFIG_DEVFS_DEBUG
devfs_debug = devfs_debug_init;
- printk ("%s: devfs_debug: 0x%0x\n", DEVFS_NAME, devfs_debug);
+ printk (KERN_INFO DEVFS_NAME ": devfs_debug: 0x%0x\n", devfs_debug);
#endif
- printk ("%s: boot_options: 0x%0x\n", DEVFS_NAME, boot_options);
+ printk (KERN_INFO DEVFS_NAME ": boot_options: 0x%0x\n", boot_options);
err = register_filesystem (&devfs_fs_type);
if (!err)
{


2002-03-11 16:39:43

by Richard Gooch

[permalink] [raw]
Subject: Re: [PATCH] KERN_INFO 2.4.19-pre2 devfs

Denis Vlasenko writes:
> Primary purpose of this patch is to make KERN_WARNING and
> KERN_INFO log levels closer to their original meaning.
> Today they are quite far from what was intended.
> Just look what kernel writes at the WARNING level
> each time you boot your box!
>
> Diff for devfs.

I've already posted a patch which adds KERN_* to all printk()'s in
devfs (devfs-patch-v199.9). I even submitted it to Marcelo, but we
were in 2.4.18-rc1 so he deferred it. It's queued for resubmission. Be
patient.

Regards,

Richard....
Permanent: [email protected]
Current: [email protected]