2002-04-12 14:46:14

by Sverker Wiberg

[permalink] [raw]
Subject: Multiple zlib.c's in 2.4.18

Doing

$ find . -name 'zlib.c'

on the Linux 2.4.18 source reveals the three zlibs

./fs/jffs2/zlib.c
./drivers/net/zlib.c
./arch/ppc/boot/lib/zlib.c

Further checking reveals that ./arch/ppc/boot/lib/zlib.c is based on
zlib-0.95, while the other two are zlib-1.0.4.

Which one should I use? Shouldn't they be merged? And what about the
double-free() bug?

/Sverker


2002-04-13 18:24:13

by Alan

[permalink] [raw]
Subject: Re: Multiple zlib.c's in 2.4.18

> Further checking reveals that ./arch/ppc/boot/lib/zlib.c is based on
> zlib-0.95, while the other two are zlib-1.0.4.
>
> Which one should I use? Shouldn't they be merged? And what about the
> double-free() bug?

There is progress going on to merge them (see 2.4.19-ac) so hopefully RSN
that question won't be worth asking.

2002-04-13 21:29:20

by Tom Rini

[permalink] [raw]
Subject: Re: Multiple zlib.c's in 2.4.18

On Sat, Apr 13, 2002 at 07:42:01PM +0100, Alan Cox wrote:
> > Further checking reveals that ./arch/ppc/boot/lib/zlib.c is based on
> > zlib-0.95, while the other two are zlib-1.0.4.
> >
> > Which one should I use? Shouldn't they be merged? And what about the
> > double-free() bug?
>
> There is progress going on to merge them (see 2.4.19-ac) so hopefully RSN
> that question won't be worth asking.

All of them that can be anyhow. I'm hoping no one will touch
arch/ppc/boot/lib/zlib.c :)

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/