2002-04-16 15:51:17

by Andries E. Brouwer

[permalink] [raw]
Subject: [NEW] A SDDR-09 driver

A moment ago I have made available on ftp.XX.kernel.org
under linux/kernel/people/aeb/sddr09.c a new SDDR-09 driver,
namely one that not only reads but also writes.

It works for me.

Will submit some version for inclusion in 2.5 next week
or so. Feedback is welcome.

Andries

[On the site mentioned one finds sddr09.c and sddr09.h.
Now that I think about it, there are a few other small
changes nearby:

diff -r /linux/2.5/linux-2.5.8/linux/drivers/usb/storage/initializers.h ./initializers.h
39a40
> #include <linux/config.h>
44a46,49
>
> #ifdef CONFIG_USB_STORAGE_SDDR09
> int sddr09_init(struct us_data *us);
> #endif

diff -r /linux/2.5/linux-2.5.8/linux/drivers/usb/storage/unusual_devs.h ./unusual_devs.h
133d132
< #endif
139c138
< US_SC_SCSI, US_PR_DPCM_USB, NULL,
---
> US_SC_SCSI, US_PR_DPCM_USB, sddr09_init,
140a140
> #endif

]


2002-04-26 05:18:46

by Akkana

[permalink] [raw]
Subject: Re: [NEW] A SDDR-09 driver

[email protected] writes:
> A moment ago I have made available on ftp.XX.kernel.org
> under linux/kernel/people/aeb/sddr09.c a new SDDR-09 driver,
> namely one that not only reads but also writes.
>
> It works for me.
>
> Will submit some version for inclusion in 2.5 next week
> or so. Feedback is welcome.

I've been using your SDDR-09 patches in both 2.4.19-pre7 and 2.5.8,
and they've been working great with my Zio. I can finally write to
the smartmedia card as well as read from it (woohoo!) and I haven't
seen any problems that weren't already there in the existing driver
(no serious problems at all).

I'd love to see your patch get checked in to both 2.4 and 2.5.
It makes the driver a lot more useful (there aren't that many working
USB smartmedia readers for Linux), and there are a fair number
of people who have this device. SDDR-09 is still marked experimental,
so those of us who use it know the risks. :-)

I wonder if it's worth mentioning in the configure help that this
also supports the Zio? I'll attach a patch for that in case you want to
include it. Curiously, the help for CONFIG_USB_STORAGE_DPCM just above
SDDR09 says it's for smartmedia as well as compact flash; but my Zio!
SM reader has product id 0003 (matching SDDR09), not 0005 (DPCM).

...Akkana


Attachments:
(No filename) (1.26 kB)
config.diff (401.00 B)
Download all attachments