2002-06-10 05:40:48

by Corporal Pisang

Subject: 2.5.21 pnpbios compile error.

Hi,

I get this error compiling 2.5.21

make[2]: Entering directory `/usr/src/linux/drivers/pnp'
gcc -Wp,-MD,.pnpbios_proc.o.d -D__KERNEL__ -I/usr/src/linux/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=athlon -nostdinc -iwithprefix include
-DKBUILD_BASENAME=pnpbios_proc -c -o pnpbios_proc.o pnpbios_proc.c
pnpbios_proc.c:193: parse error before "pnpbios_proc_init"
pnpbios_proc.c:194: warning: return type defaults to `int'
pnpbios_proc.c:248: parse error before "pnpbios_proc_exit"
pnpbios_proc.c:249: warning: return type defaults to `int'
pnpbios_proc.c:249: conflicting types for `pnpbios_proc_exit'
/usr/src/linux/include/linux/pnpbios.h:147: previous declaration of
`pnpbios_proc_exit'
pnpbios_proc.c: In function `pnpbios_proc_exit':
pnpbios_proc.c:253: warning: `return' with no value, in function returning
non-void
pnpbios_proc.c:269: warning: `return' with no value, in function returning
non-void
make[2]: *** [pnpbios_proc.o] Error 1
make[2]: Leaving directory `/usr/src/linux/drivers/pnp'
make[1]: *** [_subdir_pnp] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [drivers] Error 2


Regards.

--
-Ubaida-

2002-06-10 06:33:39

by Brad Heilbrun

Subject: Re: [PATCH] 2.5.21 pnpbios compile error.

On Mon, Jun 10, 2002 at 01:47:07PM +0800, Corporal Pisang wrote:
> I get this error compiling 2.5.21
>
> make[2]: Entering directory `/usr/src/linux/drivers/pnp'
> gcc -Wp,-MD,.pnpbios_proc.o.d -D__KERNEL__ -I/usr/src/linux/include -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
> -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
> -march=athlon -nostdinc -iwithprefix include
> -DKBUILD_BASENAME=pnpbios_proc -c -o pnpbios_proc.o pnpbios_proc.c
> pnpbios_proc.c:193: parse error before "pnpbios_proc_init"

Another casualty of the recent header cleanup. Trivial patch
below. The rest of the files in this directory look clean as far as
__init and __exit calls go.

diff -Nur linux-2.5/drivers/pnp/pnpbios_proc.c~ linux-2.5/drivers/pnp/pnpbios_proc.c
--- linux-2.5/drivers/pnp/pnpbios_proc.c~ Sun Jun 9 23:01:13 2002
+++ linux-2.5/drivers/pnp/pnpbios_proc.c Sun Jun 9 23:01:24 2002
@@ -28,6 +28,7 @@
#include <linux/types.h>
#include <linux/proc_fs.h>
#include <linux/pnpbios.h>
+#include <linux/init.h>

static struct proc_dir_entry *proc_pnp = NULL;
static struct proc_dir_entry *proc_pnp_boot = NULL;


--

Thank you,

Brad Heilbrun
Administrator, Network Operations
PayPal, Inc.
650.864.8200 - [email protected]