2002-06-16 12:37:41

by Adrian Bunk

Subject: [patch] fix .text.exit compile error in sstfb.c

Hi,

I got the following error at the final linking stage of 2.4.19-pre10
(updated to ChangeSet 1.546 from Marcelo's BK repository):

<-- snip -->

...
drivers/video/video.o: In function `sstfb_remove':
drivers/video/video.o(.text+0x6255c): undefined reference to `local
symbols in discarded section .text.exit'

<-- snip -->


The problem is that sstfb_remove is __devexit and calls sst_shutdown which
is __exit. This causes the error above when CONFIG_HOTPLUG is set.

I suggest the following fix:


--- drivers/video/sstfb.c.old Sun Jun 16 14:22:03 2002
+++ drivers/video/sstfb.c Sun Jun 16 14:23:56 2002
@@ -1694,7 +1694,7 @@
return 1;
}

-static void __exit sst_shutdown(struct sstfb_info *sst_info)
+static void __devexit sst_shutdown(struct sstfb_info *sst_info)
{
struct pci_dev * sst_dev = sst_info->dev;
struct pll_timing gfx_timings;

cu
Adrian

--

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox

2002-06-18 01:03:51

by Ghozlane Toumi

Subject: Re: [patch] fix .text.exit compile error in sstfb.c

On Sunday 16 June 2002 08:37, Adrian Bunk wrote:
> Hi,

> The problem is that sstfb_remove is __devexit and calls sst_shutdown which
> is __exit. This causes the error above when CONFIG_HOTPLUG is set.
>

Sorry for the delay,
Thank you for your patch, if Marcelo doesn't integrate it , I'll resend it to
him ...

ghoz