Hey guys.
It`s time for some real janitor work :)
I`ve taken a clean 2.5.22 tree, and started removing
instances of check_region(). It has been on the kernel janitors`
TODO list for a long time.
It struck me that it might be a good idea to see if anyone had any comments
or even objections before spending X hours killing it off :-)
I see that there are lots of places where we can just remove
check_region() and instead just check the return value from
request_region(), but I`m also sure we have corner cases where
driver authors are doing 'nifty' things with check_region(), and
these drivers might need a bit more surgery. I will contact
the driver authors and ask for their comments if I can not figure out
how to work around using check_region() in the specific driver.
When done, I`ll submit separate patches for separate directories.
Does this sound like a sane approach to you guys ?
== Morten
--
"Livet er ikke for nybegynnere" - sitat fra en klok person.
mvh
Morten Helgesen
UNIX System Administrator & C Developer
Nextframe AS
[email protected] / 93445641
http://www.nextframe.net
Ok - I`ve been informed (thanks Thomas:) that William Stinson has been
working on removing check_region() for a while now. I was not aware
of this - I have noticed, that in recent changelogs, he has been credited
for work done on code in relation to resource handling, but I did not
see any check_region() stuff in there. At a closer look, I see a couple
of check_region() entries in there. I`ll contact William and see if he could
need assistance, if not I`ll grab another kernel/janitor project :)
cheers for now,
On Tue, Jun 18, 2002 at 03:00:55PM +0200, Morten Helgesen wrote:
> Hey guys.
>
> It`s time for some real janitor work :)
>
> I`ve taken a clean 2.5.22 tree, and started removing
> instances of check_region(). It has been on the kernel janitors`
> TODO list for a long time.
>
> It struck me that it might be a good idea to see if anyone had any comments
> or even objections before spending X hours killing it off :-)
>
> I see that there are lots of places where we can just remove
> check_region() and instead just check the return value from
> request_region(), but I`m also sure we have corner cases where
> driver authors are doing 'nifty' things with check_region(), and
> these drivers might need a bit more surgery. I will contact
> the driver authors and ask for their comments if I can not figure out
> how to work around using check_region() in the specific driver.
>
> When done, I`ll submit separate patches for separate directories.
>
> Does this sound like a sane approach to you guys ?
>
> == Morten
>
> --
>
> "Livet er ikke for nybegynnere" - sitat fra en klok person.
>
> mvh
> Morten Helgesen
> UNIX System Administrator & C Developer
> Nextframe AS
> [email protected] / 93445641
> http://www.nextframe.net
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
"Livet er ikke for nybegynnere" - sitat fra en klok person.
mvh
Morten Helgesen
UNIX System Administrator & C Developer
Nextframe AS
[email protected] / 93445641
http://www.nextframe.net