2002-06-18 10:10:02

by Gerd Knorr

Subject: 2.4.19-pre build failure

Hi,

Current 2.4 BK tree failes to link the vmlinux image:

[ ... ]
-o vmlinux
init/do_mounts.o: In function `rd_load_image':
init/do_mounts.o(.text.init+0xa20): undefined reference to `change_floppy'
init/do_mounts.o: In function `rd_load_disk':
init/do_mounts.o(.text.init+0xb08): undefined reference to `change_floppy'
make: *** [vmlinux] Error 1
bogomips kraxel /work/bk/2.4/build# grep FD .config
CONFIG_BLK_DEV_FD=m
# CONFIG_FDDI is not set
bogomips kraxel /work/bk/2.4/build#

Gerd

--
You can't please everybody. And usually if you _try_ to please
everybody, the end result is one big mess.
-- Linus Torvalds, 2002-04-20

2002-06-18 10:25:15

by Adrian Bunk

Subject: Re: 2.4.19-pre build failure

On Tue, 18 Jun 2002, Gerd Knorr wrote:

> Hi,

Hi Gerd,

> Current 2.4 BK tree failes to link the vmlinux image:
>
> [ ... ]
> -o vmlinux
> init/do_mounts.o: In function `rd_load_image':
> init/do_mounts.o(.text.init+0xa20): undefined reference to `change_floppy'
> init/do_mounts.o: In function `rd_load_disk':
> init/do_mounts.o(.text.init+0xb08): undefined reference to `change_floppy'
> make: *** [vmlinux] Error 1
>...

this seems to be caused by a typo in ChangeSet 1.537.1.13 .

Does the following fix it for you?

--- init/do_mounts.c.old Tue Jun 18 12:20:12 2002
+++ init/do_mounts.c Tue Jun 18 12:20:38 2002
@@ -378,7 +378,7 @@
return sys_symlink(path + n + 5, name);
}

-#if defined(CONFIG_BLOCK_DEV_RAM) || defined(CONFIG_BLK_DEV_FD)
+#if defined(CONFIG_BLK_DEV_RAM) || defined(CONFIG_BLK_DEV_FD)
static void __init change_floppy(char *fmt, ...)
{
struct termios termios;

> Gerd

cu
Adrian

--

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox

2002-06-18 14:15:04

by Gerd Hoffmann

Subject: Re: 2.4.19-pre build failure

> > init/do_mounts.o: In function `rd_load_disk':
> > init/do_mounts.o(.text.init+0xb08): undefined reference to `change_floppy'
>
> Does the following fix it for you?
>
> -#if defined(CONFIG_BLOCK_DEV_RAM) || defined(CONFIG_BLK_DEV_FD)
> +#if defined(CONFIG_BLK_DEV_RAM) || defined(CONFIG_BLK_DEV_FD)

Yes, works.

Gerd

--
You can't please everybody. And usually if you _try_ to please
everybody, the end result is one big mess.
-- Linus Torvalds, 2002-04-20