2002-06-19 07:53:09

by Felipe Contreras

[permalink] [raw]
Subject: [PATCH] Compaq hotplug fix for 2.5.23

Hi,

This one makes posible to compile the compaq hotplug module.

--
Felipe Contreras


Attachments:
(No filename) (88.00 B)
cpq-hotplug.diff (1.39 kB)
Download all attachments

2002-06-19 17:49:52

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] Compaq hotplug fix for 2.5.23

On Wed, Jun 19, 2002 at 02:53:00AM -0500, Felipe Contreras wrote:
> Hi,
>
> This one makes posible to compile the compaq hotplug module.

But does it work?

The tqueue.h patch will fix the compile time error, but I would prefer
to put that in each .c file, and not in the .h file.

The call to run_sbin_hotplug will not bind any drivers that are already
present in the kernel to the new device. It will only call
/sbin/hotplug, which is not all that is needed.

What needs to be done is to call the same function that CardBus calls,
and remove a lot of the pci device initialization from the compaq (and
IBM) pci hotplug drivers.

It's on my list of things to do, but pretty far down, patches gladly
accepted :)

thanks,

greg k-h