2002-07-21 11:29:06

by Marcel Holtmann

[permalink] [raw]
Subject: [PATCH] Bluetooth Subsystem PC Card drivers for 2.5.27

Hi Linus,

this patch updates the PC Card drivers of the Bluetooth subsystem. It
modifies the following files:

CREDITS
MAINTAINERS
bluetooth/Config.help
drivers/bluetooth/Config.in
drivers/bluetooth/Makefile
drivers/bluetooth/bluecard_cs.c
drivers/bluetooth/bt3c_cs.c
drivers/bluetooth/dtl1_cs.c

Regards

Marcel



Attachments:
patch-2.5.27-bluetooth-pccard-drivers (68.60 kB)

2002-07-22 03:36:41

by Thunder from the hill

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth Subsystem PC Card drivers for 2.5.27

Hi,

On 21 Jul 2002, Marcel Holtmann wrote:
> this patch updates the PC Card drivers of the Bluetooth subsystem. It
> modifies the following files:

Please don't use EXPORT_NO_SYMBOLS where it's avoidable.

Regards,
Thunder
--
(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o? K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y-
------END GEEK CODE BLOCK------

2002-07-22 11:37:04

by Alan

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth Subsystem PC Card drivers for 2.5.27

On Mon, 2002-07-22 at 04:39, Thunder from the hill wrote:
> Hi,
>
> On 21 Jul 2002, Marcel Holtmann wrote:
> > this patch updates the PC Card drivers of the Bluetooth subsystem. It
> > modifies the following files:
>
> Please don't use EXPORT_NO_SYMBOLS where it's avoidable.

For 2.4 you want to use it whenever possible and a file exports no
symbols. For 2.5 EXPORT_NO_SYMBOLS is the automatic default behaviour so
you can lose the line

2002-07-22 12:03:02

by Thunder from the hill

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth Subsystem PC Card drivers for 2.5.27

Hi,

On 22 Jul 2002, Alan Cox wrote:
> For 2.4 you want to use it whenever possible and a file exports no
> symbols. For 2.5 EXPORT_NO_SYMBOLS is the automatic default behaviour so
> you can lose the line

This was clearly a 2.5 patch, where we currently want to get rid of
EXPORT_NO_SYMBOLS.

Regards,
Thunder
--
(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o? K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y-
------END GEEK CODE BLOCK------

2002-07-23 11:53:36

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth Subsystem PC Card drivers for 2.5.27

Hi,

> Please don't use EXPORT_NO_SYMBOLS where it's avoidable.

attached is the same patch without EXPORT_NO_SYMBOLS. Please apply.

Regards

Marcel


Attachments:
patch-2.5.27-bluetooth-pccard-drivers (68.40 kB)

2002-07-23 12:26:41

by Thunder from the hill

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth Subsystem PC Card drivers for 2.5.27

Hi,

On Tue, 23 Jul 2002, Ingo Molnar wrote:
> why?

Because once it became standard, we want to remove it somewhen. It's
sometimes a bit ridiculous when you read it...

Regards,
Thunder
--
(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o? K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y-
------END GEEK CODE BLOCK------

2002-07-23 12:23:30

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth Subsystem PC Card drivers for 2.5.27


> Please don't use EXPORT_NO_SYMBOLS where it's avoidable.

why?

other than since it's the default, there's no need to define it in 2.5
kernels.

Ingo

2002-07-23 12:57:43

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth Subsystem PC Card drivers for 2.5.27

On Tue, Jul 23, 2002 at 06:29:38AM -0600, Thunder from the hill wrote:

> Because once it became standard, we want to remove it somewhen. It's
> sometimes a bit ridiculous when you read it...

Completely removing it means driver maintainers need to keep
separate 2.4/2.6 versions of their drivers. The extra EXPORT_NO_SYMBOLS
is harmless, and allows single source, multi kernel version drivers.

Dave

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs