2002-07-27 17:04:37

by Art Haas

Subject: [PATCH] warning fix for ide.h

Hi.

I saw this when building 2.5.29 ...

make[2]: Entering directory `/mnt/src/linux-2.5.29/drivers/ide'
gcc -Wp,-MD,./.ide-cd.o.d -D__KERNEL__ -I/mnt/src/linux-2.5.29/include
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i586 -nostdinc -iwithprefix include -DMODULE
-DKBUILD_BASENAME=ide_cd -c -o ide-cd.o ide-cd.c
ide-cd.c: In function `ide_cdrom_do_request':
ide-cd.c:1623: warning: implicit declaration of function `ide_stall_queue'

Adding a prototype to ide.h removes the warning.

--- linux-2.5.29/include/linux/ide.h.old 2002-07-27 09:10:24.000000000 -0500
+++ linux-2.5.29/include/linux/ide.h 2002-07-27 12:00:49.000000000 -0500
@@ -656,6 +656,7 @@
extern int ide_spin_wait_hwgroup(struct ata_device *);
extern void ide_timer_expiry(unsigned long data);
extern void ata_irq_request(int irq, void *data, struct pt_regs *regs);
+extern void ide_stall_queue(struct ata_device * drive, unsigned long timeout);
extern void do_ide_request(request_queue_t * q);
extern void ide_init_subdrivers(void);


--
They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety.
-- Benjamin Franklin, Historical Review of Pennsylvania, 1759

2002-07-29 09:58:20

by Marcin Dalecki

Subject: Re: [PATCH] warning fix for ide.h

Art Haas wrote:
> Hi.
>
> I saw this when building 2.5.29 ...
>
> make[2]: Entering directory `/mnt/src/linux-2.5.29/drivers/ide'
> gcc -Wp,-MD,./.ide-cd.o.d -D__KERNEL__ -I/mnt/src/linux-2.5.29/include
> -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
> -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
> -march=i586 -nostdinc -iwithprefix include -DMODULE
> -DKBUILD_BASENAME=ide_cd -c -o ide-cd.o ide-cd.c
> ide-cd.c: In function `ide_cdrom_do_request':
> ide-cd.c:1623: warning: implicit declaration of function `ide_stall_queue'
>
> Adding a prototype to ide.h removes the warning.

Please don't bother - this function is subject to go.