2002-08-08 21:02:55

by Patrick Mansfield

[permalink] [raw]
Subject: [PATCH] 2.5.30 scsi_scan.c cleanup/rewrite

Hi -

Attached is cleanup/rewrite patch for scsi_scan.c against 2.5.30.

The only functional change is adding support for BFLAGS_LARGELUN,
it was defined before, but not used, otherwise the code should be
the functional equivalent of the pre-patch version.

The unused BFLAGS_NODISK was removed.

Tested with:

qla2300, v6 beta drivers modified for 2.5.x, with FCP switch attached
IBM 3542 (multi-LUN FC disk array, supports REPORT LUN)
SEAGATE ST118273 (FC disk drive)

serveRAID (ips driver, boot device)

AIC Adaptec 7896 with IBM-PSG ST318203LC (boot disk)

ISP1020 (qlogicisp driver) with Quantum DLT7000 tape drive attached

-- Patrick Mansfield


Attachments:
patch-scsi_scan-2.5.30.gz (29.25 kB)
patch-scsi_scan-2.5.30.gz

2002-08-09 05:33:50

by Patrick Mansfield

[permalink] [raw]
Subject: Re: [PATCH] 2.5.30 scsi_scan.c cleanup/rewrite

On Thu, Aug 08, 2002 at 02:06:16PM -0700, Patrick Mansfield wrote:
> Hi -
>
> Attached is cleanup/rewrite patch for scsi_scan.c against 2.5.30.
>

There's a bug for adapters with multiple channels (like the ServeRAID
with ips driver) not being properly scanned - it scans channel 0 again
rather than going to the next channel - patch on top of the original
patch:

--- 1.23/drivers/scsi/scsi_scan.c Thu Aug 8 09:48:01 2002
+++ edited/drivers/scsi/scsi_scan.c Thu Aug 8 16:19:31 2002
@@ -1939,6 +1939,7 @@

sdevscan->host = shost;
sdevscan->id = id;
+ sdevscan->channel = channel;
/*
* Scan LUN 0, if there is some response, scan further. Ideally, we
* would not configure LUN 0 until all LUNs are scanned.

Complete patch against 2.5.30 is now at:

http://www-124.ibm.com/storageio/gen-io/patch-scsi_scan-2.5.30-2.gz

The modified scsi_scan.c file:

http://www-124.ibm.com/storageio/gen-io/scsi_scan.c-2.5.30-2.gz

Thanks.

-- Patrick Mansfield