2002-08-20 13:29:19

by Anders Gustafsson

Subject: [PATCH] __devexit_p in drivers/net/tulip/de2104x.c

Adds __devexit_p to de_remove_one in drivers/net/tulip/de2104x.c to make it
possible to compile it with new binutils

--

//anders/g

--- a/drivers/net/tulip/de2104x.c Tue Aug 20 15:28:00 2002
+++ b/drivers/net/tulip/de2104x.c Tue Aug 20 15:28:00 2002
@@ -2136,7 +2136,7 @@
return rc;
}

-static void __exit de_remove_one (struct pci_dev *pdev)
+static void __devexit de_remove_one (struct pci_dev *pdev)
{
struct net_device *dev = pci_get_drvdata(pdev);
struct de_private *de = dev->priv;
@@ -2216,7 +2216,7 @@
.name = DRV_NAME,
.id_table = de_pci_tbl,
.probe = de_init_one,
- .remove = de_remove_one,
+ .remove = __devexit_p(de_remove_one),
#ifdef CONFIG_PM
.suspend = de_suspend,
.resume = de_resume,

2002-08-20 22:06:19

by Jeff Garzik

Subject: Re: [PATCH] __devexit_p in drivers/net/tulip/de2104x.c

Anders Gustafsson wrote:
> Adds __devexit_p to de_remove_one in drivers/net/tulip/de2104x.c to make it
> possible to compile it with new binutils

Again, de_remove_one is __exit for a reason: it's not a board people
are hotplugging.

Look at the fix I made to 2.5's include/linux/init.h recently, though --
applying just the last hunk of your patch should hopefully no longer
cause a warning.

Jeff