2002-09-11 02:04:29

by Rick Lindsley

[permalink] [raw]
Subject: 2.5.34 gendisk changes

It would seem that in 2.5.34 gendisk->part[0] no longer refers to the
whole disk, but instead refers to the first partition. Is this
correct? There isn't a struct hd_struct that refers to the whole disk
anymore?

I'm working on porting forward the sard patch for disk statistics, so I
want to make sure this is the intent and not an off-by-one bug. Other
code, though, suggests it's intentional.

Rick


2002-09-11 02:30:22

by Alexander Viro

[permalink] [raw]
Subject: Re: 2.5.34 gendisk changes



On Tue, 10 Sep 2002, Rick Lindsley wrote:

> It would seem that in 2.5.34 gendisk->part[0] no longer refers to the
> whole disk, but instead refers to the first partition. Is this
> correct? There isn't a struct hd_struct that refers to the whole disk
> anymore?
>
> I'm working on porting forward the sard patch for disk statistics, so I
> want to make sure this is the intent and not an off-by-one bug. Other
> code, though, suggests it's intentional.

It is intentional.

2002-09-11 06:01:25

by Rick Lindsley

[permalink] [raw]
Subject: Re: 2.5.34 gendisk changes

I wrote:

It would seem that in 2.5.34 gendisk->part[0] no longer refers to the
whole disk, but instead refers to the first partition. Is this
correct? There isn't a struct hd_struct that refers to the whole disk
anymore?

I'm working on porting forward the sard patch for disk statistics, so I
want to make sure this is the intent and not an off-by-one bug. Other
code, though, suggests it's intentional.

Alexander Viro replied:

It is intentional.

Great -- that helps. Is there an hd_struct for the whole disk anymore?
Are there additional changes forthcoming, or is this the extent of the
gendisk changes?

Rick