2002-09-23 18:43:47

by Matthew Wilcox

[permalink] [raw]
Subject: Configure/compile error with 2.5.38


Got an interesting one here; this combination fails to link:

CONFIG_BLK_DEV_CMD640=y
# CONFIG_BLK_DEV_IDEPCI is not set

Why not? Well.. cmd640.c is in drivers/ide/pci/ which is only
entered if CONFIG_BLK_DEV_IDEPCI, and if CONFIG_BLK_DEV_CMD640 is set,
drivers/ide/ide.c contains a reference to cmd640_vlb which is defined
in cmd640.c.

The "obvious" solution to make CMD640 depend on IDEPCI is not correct
because of the aforementioned VLB controllers. Maybe we could just add
the line:
obj-$(CONFIG_BLK_DEV_CMD640) += pci/
to drivers/ide/Makefile which is a bit of a kludge..

--
Revolutions do not require corporate support.


2002-09-23 19:32:07

by Andre Hedrick

[permalink] [raw]
Subject: Re: Configure/compile error with 2.5.38


Correct, that is why I had it scheduled to be moved into legacy.
However until many issuse are settle down minor fixes like this are on
hold.

On Mon, 23 Sep 2002, Matthew Wilcox wrote:

>
> Got an interesting one here; this combination fails to link:
>
> CONFIG_BLK_DEV_CMD640=y
> # CONFIG_BLK_DEV_IDEPCI is not set
>
> Why not? Well.. cmd640.c is in drivers/ide/pci/ which is only
> entered if CONFIG_BLK_DEV_IDEPCI, and if CONFIG_BLK_DEV_CMD640 is set,
> drivers/ide/ide.c contains a reference to cmd640_vlb which is defined
> in cmd640.c.
>
> The "obvious" solution to make CMD640 depend on IDEPCI is not correct
> because of the aforementioned VLB controllers. Maybe we could just add
> the line:
> obj-$(CONFIG_BLK_DEV_CMD640) += pci/
> to drivers/ide/Makefile which is a bit of a kludge..
>
> --
> Revolutions do not require corporate support.
>

Andre Hedrick
LAD Storage Consulting Group