Subject: [patch] stradis fixes

hi,
this patch makes stradis driver uses struct file_operations (struct
video_device changed).

--
aris


Attachments:
(No filename) (106.00 B)
stradis.patch (7.19 kB)
Download all attachments
Subject: Re: [patch] stradis fixes

> On Fri, 2002-09-27 at 18:22, Aristeu Sergio Rozanski Filho wrote:
> > hi,
> > this patch makes stradis driver uses struct file_operations (struct
> > video_device changed).
> >
>
> What are all the (void *) casts you added supposed to be for ?
stradis.c: In function `saa_ioctl':
stradis.c:1340: warning: passing arg 1 of `__constant_copy_to_user' makes
pointer from integer without a cast
stradis.c:1340: warning: passing arg 1 of `__generic_copy_to_user' makes
pointer from integer without a cast
(snip)
am I missing something?

--
aris

2002-09-27 18:20:44

by Alan

[permalink] [raw]
Subject: Re: [patch] stradis fixes

On Fri, 2002-09-27 at 18:22, Aristeu Sergio Rozanski Filho wrote:
> hi,
> this patch makes stradis driver uses struct file_operations (struct
> video_device changed).
>

What are all the (void *) casts you added supposed to be for ?


2002-09-27 19:06:15

by Alan

[permalink] [raw]
Subject: Re: [patch] stradis fixes

On Fri, 2002-09-27 at 19:33, Aristeu Sergio Rozanski Filho wrote:
> stradis.c: In function `saa_ioctl':
> stradis.c:1340: warning: passing arg 1 of `__constant_copy_to_user' makes
> pointer from integer without a cast
> stradis.c:1340: warning: passing arg 1 of `__generic_copy_to_user' makes
> pointer from integer without a cast
> (snip)
> am I missing something?

Maybe you should ask why they are integers and what else is wrong ?

Subject: Re: [patch] stradis fixes

> Maybe you should ask why they are integers and what else is wrong ?
ok, I guess I found it (?)

--
aris


Attachments:
(No filename) (107.00 B)
stradis.patch (3.62 kB)
Download all attachments