2002-09-28 08:43:58

by Andrew Morton

[permalink] [raw]
Subject: Re: [PROBLEM] 2.5.39 - might_sleep() exception - ACPI/APIC, UML compile issues on MP 2000+

Shawn Starr wrote:
>
> ...
> 3) Compile errors with UML:
>
> In file included from sched.c:19:
> /usr/src/linux-2.5.39/include/linux/mm.h:165: parse error before "pte_addr_t"
> /usr/src/linux-2.5.39/include/linux/mm.h:165: warning: no semicolon at end of struct or union
> /usr/src/linux-2.5.39/include/linux/mm.h:165: warning: no semicolon at end of struct or union
> /usr/src/linux-2.5.39/include/linux/mm.h:166: warning: type defaults to `int' in declaration of `pte'
>

It's strange that this ever worked. Does this fix?

--- linux-2.5.39/include/asm-um/pgtable.h Sun Sep 15 20:53:43 2002
+++ 25/include/asm-um/pgtable.h Sat Sep 28 01:47:43 2002
@@ -215,6 +215,8 @@ static inline void set_pte(pte_t *pteptr
if(pte_present(*pteptr)) *pteptr = pte_mknewprot(*pteptr);
}

+typedef pte_t *pte_addr_t;
+
/*
* (pmds are folded into pgds so this doesnt get actually called,
* but the define is needed for a generic inline function.)


2002-09-29 01:21:42

by Shawn Starr

[permalink] [raw]
Subject: Re: [PROBLEM] 2.5.39 - might_sleep() exception - ACPI/APIC, UML compile issues on MP 2000+


I don't get that error anymore but UML won't compile:

Unless im doing something wrong this is how i've been building UML (in 2.4)

make menuconfig ARCH=um
make modules ARCH=um
make modules_install ARCH=um
make linux ARCH=um

Is this correct?

Shawn.

On September 28, 2002 04:49 am, Andrew Morton wrote:

> Shawn Starr wrote:
> > ...
> > 3) Compile errors with UML:
> >
> > In file included from sched.c:19:
> > /usr/src/linux-2.5.39/include/linux/mm.h:165: parse error before
> > "pte_addr_t" /usr/src/linux-2.5.39/include/linux/mm.h:165: warning: no
> > semicolon at end of struct or union
> > /usr/src/linux-2.5.39/include/linux/mm.h:165: warning: no semicolon at
> > end of struct or union /usr/src/linux-2.5.39/include/linux/mm.h:166:
> > warning: type defaults to `int' in declaration of `pte'
>
> It's strange that this ever worked. Does this fix?
>
> --- linux-2.5.39/include/asm-um/pgtable.h Sun Sep 15 20:53:43 2002
> +++ 25/include/asm-um/pgtable.h Sat Sep 28 01:47:43 2002
> @@ -215,6 +215,8 @@ static inline void set_pte(pte_t *pteptr
> if(pte_present(*pteptr)) *pteptr = pte_mknewprot(*pteptr);
> }
>
> +typedef pte_t *pte_addr_t;
> +
> /*
> * (pmds are folded into pgds so this doesnt get actually called,
> * but the define is needed for a generic inline function.)

2002-09-29 01:43:02

by Jeff Dike

[permalink] [raw]
Subject: Re: [PROBLEM] 2.5.39 - might_sleep() exception - ACPI/APIC, UML compile issues on MP 2000+

[email protected] said:
> I don't get that error anymore but UML won't compile:

The 2.5.39 UML doesn't build. I'm working on it.

Jeff

2002-10-01 01:35:44

by Jeff Dike

[permalink] [raw]
Subject: Re: [PROBLEM] 2.5.39 - might_sleep() exception - ACPI/APIC, UML compile issues on MP 2000+

[email protected] said:
> It's strange that this ever worked. Does this fix?

Yes it does, but it is better to extract the definition from the ifdefs that
I blindly copied from i386.

Jeff