2002-09-30 01:15:51

by Andries E. Brouwer

Subject: init ordering bug in 802/psnap.c vs llc/llc_main.c

> Humm, 2.5.39? It is compiled statically, isn't it?
> I'm working exclusively with modules up to now

A good hint. llc/llc_main.c crashes in llc_sap_find()
because llc_init() has not yet been called, so that
llc_main_station.sap_list.list is not initialized.

And llc_sap_find() was called from 802/psnap.c, in snap_init().

Calling llc_init() and snap_init() in the right order
makes the oops go away.

Andries

2002-09-30 01:18:47

by Arnaldo Carvalho de Melo

Subject: Re: init ordering bug in 802/psnap.c vs llc/llc_main.c

Em Mon, Sep 30, 2002 at 03:21:12AM +0200, [email protected] escreveu:
> > Humm, 2.5.39? It is compiled statically, isn't it?
> > I'm working exclusively with modules up to now
>
> A good hint. llc/llc_main.c crashes in llc_sap_find()
> because llc_init() has not yet been called, so that
> llc_main_station.sap_list.list is not initialized.
>
> And llc_sap_find() was called from 802/psnap.c, in snap_init().
>
> Calling llc_init() and snap_init() in the right order
> makes the oops go away.

Thanks for investigating and reporting :-)

- Arnaldo