Russell,
I was getting a NULL pointer dereference in __release_resource when I tried
to boot 2.5.41. I traced it down to your recent patch to 8250.c. Since
the call to serial8250_request_std_resource() is now conditional, the call
to release_resource() needs to be conditional as well. This patch fixes
the problem. It looks obviously correct to me, but I don't know this code
at all.
Thanks,
Shaggy
diff -Nur linux-2.5.41/drivers/serial/8250.c linux/drivers/serial/8250.c
--- linux-2.5.41/drivers/serial/8250.c Wed Oct 9 11:16:52 2002
+++ linux/drivers/serial/8250.c Wed Oct 9 11:17:19 2002
@@ -1636,7 +1636,7 @@
if (up->port.type != PORT_RSA && res_rsa)
release_resource(res_rsa);
- if (up->port.type == PORT_UNKNOWN)
+ if (up->port.type == PORT_UNKNOWN && res_std)
release_resource(res_std);
}
On Wed, Oct 09, 2002 at 12:19:11PM -0500, David Kleikamp wrote:
> I was getting a NULL pointer dereference in __release_resource when I tried
> to boot 2.5.41. I traced it down to your recent patch to 8250.c. Since
> the call to serial8250_request_std_resource() is now conditional, the call
> to release_resource() needs to be conditional as well. This patch fixes
> the problem. It looks obviously correct to me, but I don't know this code
> at all.
Oddly, I've also sent this patch out in the last couple of days. 8)
Its correct.
--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
On Wednesday 09 October 2002 12:54, Russell King wrote:
>
> Oddly, I've also sent this patch out in the last couple of days. 8)
> Its correct.
Okay, I found it now. It was the second part of a patch that fixed
another problem.
Thanks,
Shaggy
--
David Kleikamp
IBM Linux Technology Center