2002-10-12 08:18:13

by Andres Salomon

[permalink] [raw]
Subject: [PATCH] sparc64 makefile dep fix for uart_console_init

drivers/serial/Config.in defines the following:
if [ "$CONFIG_SPARC32" = "y" -o "$CONFIG_SPARC64" = "y" ]; then
define_bool CONFIG_SERIAL_SUNCORE y
define_bool CONFIG_SERIAL_CORE_CONSOLE y

There are no deps for CONFIG_SERIAL_CORE_CONSOLE in
drivers/serial/Makefile, so core.o isn't built on sparc32/64, and
linking gives an undefined reference to uart_console_init() error. Not
sure if this is the desired way to deal w/ such deps, but it gets the
job done.

--
It's not denial. I'm just selective about the reality I accept.
-- Bill Watterson


Attachments:
(No filename) (551.00 B)
serialmake.diff (454.00 B)
Download all attachments

2002-10-12 08:35:58

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] sparc64 makefile dep fix for uart_console_init

From: Andres Salomon <[email protected]>
Date: Sat, 12 Oct 2002 04:24:05 -0400

drivers/serial/Config.in defines the following:
if [ "$CONFIG_SPARC32" = "y" -o "$CONFIG_SPARC64" = "y" ]; then
define_bool CONFIG_SERIAL_SUNCORE y
define_bool CONFIG_SERIAL_CORE_CONSOLE y

There are no deps for CONFIG_SERIAL_CORE_CONSOLE in
drivers/serial/Makefile

Yeah that's weird. Just enable one of the sun serial
drivers for now and it will fix itself.

Probably a fix could be to add CONFIG_SERIAL_SUNCORE to the
checks that set CONFIG_SERIAL_CORE, I think that's how I'll
fix this.

2002-10-12 08:48:04

by Russell King

[permalink] [raw]
Subject: Re: [PATCH] sparc64 makefile dep fix for uart_console_init

On Sat, Oct 12, 2002 at 01:35:07AM -0700, David S. Miller wrote:
> Probably a fix could be to add CONFIG_SERIAL_SUNCORE to the
> checks that set CONFIG_SERIAL_CORE, I think that's how I'll
> fix this.

Agreed. Do you want me to make the change?

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html

2002-10-12 09:08:16

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] sparc64 makefile dep fix for uart_console_init

From: Russell King <[email protected]>
Date: Sat, 12 Oct 2002 09:53:48 +0100

On Sat, Oct 12, 2002 at 01:35:07AM -0700, David S. Miller wrote:
> Probably a fix could be to add CONFIG_SERIAL_SUNCORE to the
> checks that set CONFIG_SERIAL_CORE, I think that's how I'll
> fix this.

Agreed. Do you want me to make the change?

Yes, please do.