OK, I redid this with subarch support. It's now new and shiny and gets
whites whiter. Actually came out smaller and cleaner, so maybe doing
The Right Thing (tm) is good sometimes ;-) Retested.
This set of 5 patches puts in the core support for the Summit chipset
used by IBM x440 machines - this is a major new platform for IBM, and
we'd really like to have it supported in 2.6 ... the changes are actually
pretty small, it keys off a lot of the same stuff as the NUMA-Q.
I've taken James Cleverdon's patches (he did all the hard work on this)
and split it into bite-sized chunks, where each patch is small, confined
and (IMHO) easily readable, and it should be easy to see it won't break
anything else.
I've dropped some cleanup work that he did - you seem to like that seperate
from features, and I agree ... it's much easier to read the patches like this.
I will invest some serious effort and time in cleanup after the feature freeze,
including investigating using the subarch support which I know some people
would like to see done.
There is an x86_summit switch variable which is needed because
distributions want the same kernel to boot on Summit as other platforms. For
most people, just leaving CONFIG_X86_SUMMIT turned off will give them
exactly the same code as they had before, with no switching. Alan wanted
it to work this way to make debugging easier, and simplify the common case.
I've also tested these on a standard desktop PC, a standard 4-way SMP box,
and a 16-way NUMA-Q (against 2.5.42). No problems found.
Please apply!
Thanks,
Martin.
On Mon, Oct 14, 2002 at 03:27:28PM -0700, Martin J. Bligh wrote:
>
> There is an x86_summit switch variable which is needed because
> distributions want the same kernel to boot on Summit as other platforms. For
> most people, just leaving CONFIG_X86_SUMMIT turned off will give them
> exactly the same code as they had before, with no switching. Alan wanted
> it to work this way to make debugging easier, and simplify the common case.
I don't really agree with this switch variable, but if you and James are
willing to duplicate all of the code... :)
Other than that, the patches look nice. _Very_ nice compared to the
original ones, good job.
thanks,
greg k-h