2002-10-18 21:19:40

by Wiktor Wodecki

[permalink] [raw]
Subject: patch for linux/usb.h

hi there,

missing urb_t typedef

--
Regards,

Wiktor Wodecki | http://johoho.eggheads.org


Attachments:
(No filename) (100.00 B)
usb_patch (446.00 B)
Download all attachments

2002-10-18 21:29:52

by Greg KH

[permalink] [raw]
Subject: Re: patch for linux/usb.h

On Fri, Oct 18, 2002 at 11:25:32PM +0200, Wiktor Wodecki wrote:
> +} urb_t;
> -};

Heh, you're kidding me, right?

No, that's not "missing" it was taken out because it should have never
gotten there in the first place.

thanks,

greg k-h

2002-10-18 21:46:28

by Greg KH

[permalink] [raw]
Subject: Re: patch for linux/usb.h

On Fri, Oct 18, 2002 at 11:45:19PM +0200, Wiktor Wodecki wrote:
> > > +} urb_t;
> > > -};
> >
> > No, that's not "missing" it was taken out because it should have never
> > gotten there in the first place.
>
> hmmm, it might "not be a good thing" to change an interface in a stable
> kernel series. this, for example, broke my quickcam express video cam
> driver. It might be wrong there, however I think we should leave it
> there...not apply this to 2.5 then

Sorry, but I fixed up all in-kernel instances of this usage. If you
want to keep a driver outside of the main kernel tree, you're going to
have to get used to things like this. In fact, this is a very minor
change, wait until some of the other USB API changes that have happened
in 2.5 get backported to 2.4 :)

Good luck,

greg k-h

2002-10-18 21:39:25

by Wiktor Wodecki

[permalink] [raw]
Subject: Re: patch for linux/usb.h

> > +} urb_t;
> > -};
>
> No, that's not "missing" it was taken out because it should have never
> gotten there in the first place.

hmmm, it might "not be a good thing" to change an interface in a stable
kernel series. this, for example, broke my quickcam express video cam
driver. It might be wrong there, however I think we should leave it
there...not apply this to 2.5 then

--
Regards,

Wiktor Wodecki | http://johoho.eggheads.org