2002-10-23 00:40:58

by Frank Davis

[permalink] [raw]
Subject: [PATCH] 2.5.44-ac1 : init/do_mounts.c

Hello all,
This patch removes an outdated macro STATIC.
Regards,
Frank

--- linux/init/do_mounts.c.old Tue Oct 22 18:23:11 2002
+++ linux/init/do_mounts.c Tue Oct 22 19:39:30 2002
@@ -844,8 +844,6 @@
#define Tracec(c,x)
#define Tracecv(c,x)

-#define STATIC static
-
static int fill_inbuf(void);
static void flush_window(void);
static void *malloc(int size);


2002-10-23 22:08:31

by James Bottomley

[permalink] [raw]
Subject: Re: [PATCH] 2.5.44-ac1 : init/do_mounts.c

> This patch removes an outdated macro STATIC.

I don't think you want to do this. The definition STATIC alters the behaviour
of the #included "lib/inflate.c" which is used for uncompressing ramdisks. I
think you'll find do_mounts.c may not even compile with it undefined since it
will now look for a missing "gzip.h" header.

James



2002-10-23 22:25:53

by Frank Davis

[permalink] [raw]
Subject: Re: [PATCH] 2.5.44-ac1 : init/do_mounts.c

James,
lib/inflate.c has a patch as well to remove STATIC.
Regards,
Frank

James Bottomley wrote:
>> This patch removes an outdated macro STATIC.
>
>
> I don't think you want to do this. The definition STATIC alters the behaviour
> of the #included "lib/inflate.c" which is used for uncompressing ramdisks. I
> think you'll find do_mounts.c may not even compile with it undefined since it
> will now look for a missing "gzip.h" header.
>
> James
>
>
>
>