2002-10-27 08:32:01

by Adam J. Richter

[permalink] [raw]
Subject: Patch(2.5.44 and 2.4.x): 6 files referenced pci_dev.driver_data instead of pci_{g,s}et_drv_data

Six driver in linux-2.5.44 directly reference
pci_dev.driver_data. This patch makes them use pci_{get,set}_drv_data
instead.

This patch is of more than just academic interest, as I intend
to submit a patch shortly for 2.5 that will eliminate
pci_dev.driver_data in favor of pci_dev.dev.driver_data. By applying
these changes to both 2.5.44 and your 2.4 trees if you maintiain them,
it will be one less difference between 2.4 and 2.5 for you to think
about.

I have verified that the updated drivers compile without any
warnings related to this change (one of IDE drivers has some other
warnings). I have not otherwise tested these changes, but they should
compile to the same object code as before.

I would appreciate it if you would apply these changes to your
respective drivers and forward the changes for your drivers to Linus.
If you would prefer that I send the changes to Linus or follow some
other course of action I can, but I think requires few of Linus's CPU
cycles when changes for a driver are emailed from that driver's
maintainer. If I have failed to contact the appropriate maintainer,
please let me know.


Modified files I think maintainers are...

drivers/block/umem.c [email protected]
[email protected]
[email protected]

drivers/ide/pci/hpt366.c [email protected]
drivers/ide/pci/siimage.c [email protected]
[email protected]

drivers/net/tokenring/3c359.c [email protected]
[email protected]

drivers/net/tulip/xircom_cb.c [email protected]

drivers/net/wan/pc300_drv.c [email protected]

--
Adam J. Richter __ ______________ 575 Oroville Road
[email protected] \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."


Attachments:
(No filename) (1.80 kB)
diff (6.51 kB)
Download all attachments

2002-10-27 15:01:04

by Jeff Garzik

[permalink] [raw]
Subject: Re: Patch(2.5.44 and 2.4.x): 6 files referenced pci_dev.driver_data instead of pci_{g,s}et_drv_data

Patch looks good to me. I'll queue for Linus unless someone else has
already done so.

could you be talked into doing a similar patch for 2.4.x?