2002-11-01 10:19:42

by Adam J. Richter

[permalink] [raw]
Subject: Patch: linux-2.5.45/fs/fcblist.c - export symbols for unix sockets

linux-2.5.45/fs/fcblist.c contains some symbols that are
needed for unix domain sockets if unix sockets are compiled as a
module. fcblist.o is already in the export-objs declaration in
fs/Makefile, so I think the intention was for the EXPORT_SYMBOL
declarations to be in that file.

Here is the patch. I have verified that unix domain sockets
load with this patch (possibly with some more EXPORT_SYMBOL changes in
my netsyms.c, which has a bunch of additional exports).

Davide: please let me know if this patch is OK (others are
welcome to comment too), and, if so, if you are going to forward this
to Linus or if you want me to do something more.

--
Adam J. Richter __ ______________ 575 Oroville Road
[email protected] \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."


Attachments:
(No filename) (922.00 B)
fcblist.diff (559.00 B)
Download all attachments

2002-11-01 16:45:32

by Davide Libenzi

[permalink] [raw]
Subject: Re: Patch: linux-2.5.45/fs/fcblist.c - export symbols for unix sockets

On Fri, 1 Nov 2002, Adam J. Richter wrote:

> linux-2.5.45/fs/fcblist.c contains some symbols that are
> needed for unix domain sockets if unix sockets are compiled as a
> module. fcblist.o is already in the export-objs declaration in
> fs/Makefile, so I think the intention was for the EXPORT_SYMBOL
> declarations to be in that file.
>
> Here is the patch. I have verified that unix domain sockets
> load with this patch (possibly with some more EXPORT_SYMBOL changes in
> my netsyms.c, which has a bunch of additional exports).
>
> Davide: please let me know if this patch is OK (others are
> welcome to comment too), and, if so, if you are going to forward this
> to Linus or if you want me to do something more.

I'll put this in my next patch to Linus. Exports were there in the
original patch ( /dev/epoll ) but after being caught by a cleanup phobia I
nuke them all :)



- Davide