Anyone else seeing this error message? I figured out what it _actually_
means is that the character `-' is not permitted in the symbol being
exported. so if we change include-config to include_config in Makefile
and scripts/Makefile.build, everything is fine.
How about the following patch?
diff -u -p -r1.1.2.6 Makefile
--- Makefile 31 Oct 2002 17:26:55 -0000 1.1.2.6
+++ Makefile 3 Nov 2002 03:15:06 -0000
@@ -214,7 +216,7 @@ SUBDIRS :=
ifeq ($(filter $(noconfig_targets),$(MAKECMDGOALS)),)
-export include-config := 1
+export include_config := 1
-include .config
diff -u -p -r1.1.2.1 Makefile.build
--- scripts/Makefile.build 31 Oct 2002 17:28:39 -0000 1.1.2.1
+++ scripts/Makefile.build 3 Nov 2002 03:15:06 -0000
@@ -7,7 +7,7 @@ src := $(obj)
.PHONY: __build
__build:
-ifdef include-config
+ifdef include_config
include .config
endif
--
Revolutions do not require corporate support.
On Sat, 2002-11-02 at 19:18, Matthew Wilcox wrote:
> Anyone else seeing this error message? I figured out what it _actually_
> means is that the character `-' is not permitted in the symbol being
> exported. so if we change include-config to include_config in Makefile
> and scripts/Makefile.build, everything is fine.
>
> How about the following patch?
Nice work Matthew, although you missed cleaning up a few remaining
'include-config' references in comments.
Kai, this fixes the problem I reported to you on sparc64 with
make-3.79 What version of make do you have which accepted this
variable name with a dash in it?
On 02 Nov 2002 22:20:11 -0800,
"David S. Miller" <[email protected]> wrote:
>Kai, this fixes the problem I reported to you on sparc64 with
>make-3.79 What version of make do you have which accepted this
>variable name with a dash in it?
The message is not coming from make, make accepts almost any variable
name in export. The message comes from bash, which restricts the
format of exported names.
> Date: Sun, 3 Nov 2002 13:17:22 -0600 (CST)
> From: Kai Germaschewski <[email protected]>
> > > Anyone else seeing this error message? I figured out what it _actually_
> > > means is that the character `-' is not permitted in the symbol being
> > > exported. so if we change include-config to include_config in Makefile
> > > and scripts/Makefile.build, everything is fine.
> Makes me wonder if Pete's exporting of 'INIT-Y' is a good idea, you may
> want to change that to '_' as well.
Sorry about that. It's already submitted, so I'll wait until
it recycles through Dave's tree then change it. Thanks for letting
me know, Kai.
-- Pete
On 2 Nov 2002, David S. Miller wrote:
> On Sat, 2002-11-02 at 19:18, Matthew Wilcox wrote:
> > Anyone else seeing this error message? I figured out what it _actually_
> > means is that the character `-' is not permitted in the symbol being
> > exported. so if we change include-config to include_config in Makefile
> > and scripts/Makefile.build, everything is fine.
> >
> > How about the following patch?
>
> Nice work Matthew, although you missed cleaning up a few remaining
> 'include-config' references in comments.
>
> Kai, this fixes the problem I reported to you on sparc64 with
> make-3.79 What version of make do you have which accepted this
> variable name with a dash in it?
Thank you guys, I'll push it to Linus if it's not merged already. As
other people pointed out, it seems to be that various version of bash/sh
seem to handle the '-' differently.
Makes me wonder if Pete's exporting of 'INIT-Y' is a good idea, you may
want to change that to '_' as well.
--Kai
From: Pete Zaitcev <[email protected]>
Date: Sun, 3 Nov 2002 14:22:23 -0500
> Makes me wonder if Pete's exporting of 'INIT-Y' is a good idea, you may
> want to change that to '_' as well.
Sorry about that. It's already submitted, so I'll wait until
it recycles through Dave's tree then change it. Thanks for letting
me know, Kai.
None of your patches are applied yes, please feel free to submit
a new batch and I will wait for that.