2002-11-07 20:03:35

by Denis Zaitsev

[permalink] [raw]
Subject: [PATCH] [TRIVIAL] hda: DMA disabled

I have such a pessimistic messages at the startup, and nothing
relaxing is following, keeping such a feeling that DMA is really
disabled. The tiny patch below brings the patiency, even though I'm
not sure that this is the exact way. So, please apply, if it's
appropriate.


--- drivers/ide/ide-iops.c.orig Thu Nov 7 23:14:03 2002
+++ drivers/ide/ide-iops.c Thu Nov 7 23:15:01 2002
@@ -891,7 +891,7 @@ int ide_config_drive_speed (ide_drive_t
if (speed >= XFER_SW_DMA_0)
hwif->ide_dma_host_on(drive);
else
- hwif->ide_dma_off(drive);
+ hwif->ide_dma_off_quietly(drive);
#endif /* (CONFIG_BLK_DEV_IDEDMA) && !(CONFIG_DMA_NONPCI) */

switch(speed) {


2002-11-08 16:32:13

by Alan

[permalink] [raw]
Subject: Re: [PATCH] [TRIVIAL] hda: DMA disabled

On Thu, 2002-11-07 at 20:01, Denis Zaitsev wrote:
> I have such a pessimistic messages at the startup, and nothing
> relaxing is following, keeping such a feeling that DMA is really
> disabled. The tiny patch below brings the patiency, even though I'm
> not sure that this is the exact way. So, please apply, if it's
> appropriate.

We are going to need more not less debug before 2.6. When its 2.6-rc
then yes its time to quieten down but not while the IDE is stil being
debugged