2002-11-10 21:04:30

by Daniel Mehrmann

[permalink] [raw]
Subject: [PATCH] [2.4.20-rc1] compiler fix drivers/ide/pdc202xx.c

Hello Marcelo,

i fix a compiler warning from pdc202xx.c.
The "default:" value in the switch was empty. Gcc don`t like
this. We don`t need this one.

error:
gcc -D__KERNEL__ -I/usr/src/bk/work-2.4/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2
-march=athlon-tbird -nostdinc -iwithprefix include
-DKBUILD_BASENAME=pdc202xx -c -o pdc202xx.o pdc202xx.c
pdc202xx.c: In function `pdc202xx_new_tune_chipset':
pdc202xx.c:636: warning: deprecated use of label at end of compound
statement

patch:
daniel@deepblue:/usr/src/bk/linux-2.4/drivers/ide$ diff -Pu
pdc202xx.c pdc202xx.c.fine
--- pdc202xx.c 2002-11-03 04:55:30.000000000 +0100
+++ pdc202xx.c.fine 2002-11-10 21:55:43.000000000 +0100
@@ -632,11 +632,10 @@
OUT_BYTE((0x13 + adj),
indexreg);
OUT_BYTE(0xac, datareg);
break;
- default:
}
}
}
return err;
}

greetings,
Daniel



Subject: Re: [PATCH] [2.4.20-rc1] compiler fix drivers/ide/pdc202xx.c

Daniel Mehrmann <[email protected]> writes:

>Hello Marcelo,

>i fix a compiler warning from pdc202xx.c.
>The "default:" value in the switch was empty. Gcc don`t like
>this. We don`t need this one.

Correct solution is not to remove the "default:" but to add a "break;"

Regards
Henning

--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH [email protected]

Am Schwabachgrund 22 Fon.: 09131 / 50654-0 [email protected]
D-91054 Buckenhof Fax.: 09131 / 50654-20

2002-11-11 14:56:00

by Horst H. von Brand

[permalink] [raw]
Subject: Re: [PATCH] [2.4.20-rc1] compiler fix drivers/ide/pdc202xx.c

"Henning P. Schmiedehausen" <[email protected]> said:
> Daniel Mehrmann <[email protected]> writes:
>
> >Hello Marcelo,
>
> >i fix a compiler warning from pdc202xx.c.
> >The "default:" value in the switch was empty. Gcc don`t like
> >this. We don`t need this one.
>
> Correct solution is not to remove the "default:" but to add a "break;"

So people start wondering if somehow the content of the default case got
deleted by mistake? Better not. Plus it is needless (source) code bloat.
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513

Subject: Re: [PATCH] [2.4.20-rc1] compiler fix drivers/ide/pdc202xx.c

Horst von Brand <[email protected]> writes:

>"Henning P. Schmiedehausen" <[email protected]> said:
>> Daniel Mehrmann <[email protected]> writes:
>>
>> >Hello Marcelo,
>>
>> >i fix a compiler warning from pdc202xx.c.
>> >The "default:" value in the switch was empty. Gcc don`t like
>> >this. We don`t need this one.
>>
>> Correct solution is not to remove the "default:" but to add a "break;"

>So people start wondering if somehow the content of the default case got
>deleted by mistake? Better not. Plus it is needless (source) code bloat.

So comment it:

default:
break; /* Does nothing */

A switch without a default case is simply asking for trouble in the
long run.

Regards
Henning


--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH [email protected]

Am Schwabachgrund 22 Fon.: 09131 / 50654-0 [email protected]
D-91054 Buckenhof Fax.: 09131 / 50654-20