2002-11-13 22:20:23

by Bob Miller

Subject: [TRIVIAL PATCH 2.5.47] Remove compile warning from scsi/scsi.c

diff -Nru a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
--- a/drivers/scsi/scsi.c Wed Nov 13 14:09:57 2002
+++ b/drivers/scsi/scsi.c Wed Nov 13 14:09:57 2002
@@ -1985,7 +1985,7 @@
up_read(&scsi_devicelist_mutex);
return 0;

-fail:
+/* XXX fail: */
printk(KERN_ERR "%s: Allocation failure during SCSI scanning, "
"some SCSI devices might not be configured\n",
__FUNCTION__);
--
Bob Miller Email: [email protected]
Open Source Development Lab Phone: 503.626.2455 Ext. 17

2002-12-02 05:25:05

by Rusty Russell

Subject: Re: [TRIVIAL PATCH 2.5.47] Remove compile warning from scsi/scsi.c

In message <[email protected]> you write:
> diff -Nru a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
> --- a/drivers/scsi/scsi.c Wed Nov 13 14:09:57 2002
> +++ b/drivers/scsi/scsi.c Wed Nov 13 14:09:57 2002
> @@ -1985,7 +1985,7 @@
> up_read(&scsi_devicelist_mutex);
> return 0;
>
> -fail:
> +/* XXX fail: */
> printk(KERN_ERR "%s: Allocation failure during SCSI scanning, "
> "some SCSI devices might not be configured\n",
> __FUNCTION__);

That code is now unreachable, which can't be right.

(Catching up on trivial),
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.