2002-11-18 20:29:05

by Gregoire Favre

[permalink] [raw]
Subject: 2.5.48 and SCSI ?

Hello,

I have applied the patch sent today, but the kernel don't find my root
(aic7xxx), what I got is:

SCSI subsystem driver Revision: 1.00
scsi0 : Adaptec AIC7XXX EISA/VLB/PCI SCSI HBA DRIVER, Rev 6.2.4
<Adaptec 29160B Ultra160 SCSI adapter>
aic7892: Ultra160 Wide Channel A, SCSI Id=7, 32/253 SCBs

(scsi0:A:0): 80.000MB/s transfers (40.000MHz, offset 15, 16bit)
Vendor: IBM Model: DDRS-39130D Rev: DC1B
Type: Direct-Access ANSI SCSI revision: 02
(scsi0:A:15): 80.000MB/s transfers (40.000MHz, offset 63, 16bit)
(scsi0:A:15): 160.000MB/s transfers (80.000MHz DT, offset 63, 16bit)
Vendor: SEAGATE Model: ST336706LW Rev: 0108
Type: Direct-Access ANSI SCSI revision: 03
scsi1 : Adaptec AIC7XXX EISA/VLB/PCI SCSI HBA DRIVER, Rev 6.2.4
<Adaptec 2940 Ultra SCSI adapter>
aic7880: Ultra Single Channel A, SCSI Id=7, 16/253 SCBs

(scsi1:A:1): 10.000MB/s transfers (10.000MHz, offset 15)
Vendor: TOSHIBA Model: DVD-ROM SD-M1201 Rev: 1R04
Type: CD-ROM ANSI SCSI revision: 02
(scsi1:A:2): 10.000MB/s transfers (10.000MHz, offset 8)
Vendor: PLEXTOR Model: CD-R PX-R820T Rev: 1.08
Type: CD-ROM ANSI SCSI revision: 02
(scsi1:A:3): 10.000MB/s transfers (10.000MHz, offset 8)
Vendor: PLEXTOR Model: CD-R PX-R820T Rev: 1.08
Type: CD-ROM ANSI SCSI revision: 02
(scsi1:A:4): 10.000MB/s transfers (10.000MHz, offset 15)
Vendor: PIONEER Model: CD-ROM DR-U06S Rev: 1.05
Type: CD-ROM ANSI SCSI revision: 02
scsi0:A:0:0: Tagged Queuing enabled. Depth 253
SCSI device sda: drive cache: write through
SCSI device sda: 17850000 512-byte hdwr sectors (9139 MB)
/dev/scsi/host0/bus0/target0/lun0: p1 p2
Attached scsi disk sda at scsi0, channel 0, id 0, lun 0
scsi0:A:15:0: Tagged Queuing enabled. Depth 253
SCSI device sdb: drive cache: write back
SCSI device sdb: 71687370 512-byte hdwr sectors (36704 MB)
/dev/scsi/host0/bus0/target15/lun0: p1 p2
Attached scsi disk sdb at scsi0, channel 0, id 15, lun 0
sr0: scsi3-mmc drive: 32x/32x cd/rw xa/form2 cdda tray
Uniform CD-ROM driver Revision: 3.12
sr1: scsi3-mmc drive: 20x/20x writer cd/rw xa/form2 cdda tray
sr2: scsi3-mmc drive: 20x/20x writer cd/rw xa/form2 cdda tray
sr3: scsi3-mmc drive: 32x/32x cd/rw xa/form2 cdda tray

While the diff against 2.4.45:

1,2c1,2
< SCSI device : drive cache: write through
< SCSI device : 17850000 512-byte hdwr sectors (9139 MB)
---
> SCSI device sda: drive cache: write through
> SCSI device sda: 17850000 512-byte hdwr sectors (9139 MB)
5,6c5,6
< SCSI device : drive cache: write back
< SCSI device : 71687370 512-byte hdwr sectors (36704 MB)
---
> SCSI device sdb: drive cache: write back
> SCSI device sdb: 71687370 512-byte hdwr sectors (36704 MB)
11d10
< Attached scsi CD-ROM sr0 at scsi1, channel 0, id 1, lun 0
13d11
< Attached scsi CD-ROM sr1 at scsi1, channel 0, id 2, lun 0
15d12
< Attached scsi CD-ROM sr2 at scsi1, channel 0, id 3, lun 0
17d13
< Attached scsi CD-ROM sr3 at scsi1, channel 0, id 4, lun 0

Should I try without the patch?

Thank you very much,

Gr?goire
________________________________________________________________
http://ulima.unil.ch/greg ICQ:16624071 mailto:[email protected]


2002-11-18 21:06:31

by Gregoire Favre

[permalink] [raw]
Subject: Re: 2.5.48 and SCSI ?

Hello,

same result with vanilla with just this devfs patch:

802,804c802,804
< struct timespec atime;
< struct timespec mtime;
< struct timespec ctime;
---
> time_t atime;
> time_t mtime;
> time_t ctime;
2512,2514c2512,2514
< de->inode.atime = inode->i_atime;
< de->inode.mtime = inode->i_mtime;
< de->inode.ctime = inode->i_ctime;
---
> de->inode.atime = inode->i_atime.tv_sec;
> de->inode.mtime = inode->i_mtime.tv_sec;
> de->inode.ctime = inode->i_ctime.tv_sec;
2613,2615c2613,2618
< inode->i_atime = de->inode.atime;
< inode->i_mtime = de->inode.mtime;
< inode->i_ctime = de->inode.ctime;
---
> inode->i_atime.tv_sec = de->inode.atime;
> inode->i_mtime.tv_sec = de->inode.mtime;
> inode->i_ctime.tv_sec = de->inode.ctime;
> inode->i_atime.tv_nsec = 0;
> inode->i_mtime.tv_nsec = 0;
> inode->i_ctime.tv_nsec = 0;

Isn't that the right fix for fs/devfs/base.c ?

Thank you very much,

Gr?goire
________________________________________________________________
http://ulima.unil.ch/greg ICQ:16624071 mailto:[email protected]

2002-11-18 21:26:58

by Kai Mäkisara (Kolumbus)

[permalink] [raw]
Subject: Re: 2.5.48 and SCSI ?

On Mon, 18 Nov 2002, Gregoire Favre wrote:

> Hello,
>
> I have applied the patch sent today, but the kernel don't find my root
> (aic7xxx), what I got is:
>
I had the same problem with sym53c8xxx_2 when devfs was configured into
the kernel (but not mounted). Then I made a kernel with devfs disabled and
now this boots (and seems to work).

--
Kai

2002-11-18 21:42:22

by Gregoire Favre

[permalink] [raw]
Subject: Re: 2.5.48 and SCSI ? (devfs problem!!!)

On Mon, Nov 18, 2002 at 11:33:58PM +0200, Kai Makisara wrote:
> On Mon, 18 Nov 2002, Gregoire Favre wrote:
>
> > Hello,
> >
> > I have applied the patch sent today, but the kernel don't find my root
> > (aic7xxx), what I got is:
> >
> I had the same problem with sym53c8xxx_2 when devfs was configured into
> the kernel (but not mounted). Then I made a kernel with devfs disabled and
> now this boots (and seems to work).

Hello,

well, I "need" devfs and it is mounted... I really don't want to create
all the devices I use... At least now I know where does the prolem come
from ;-)

Thank you very much,

Gr?goire
________________________________________________________________
http://ulima.unil.ch/greg ICQ:16624071 mailto:[email protected]

2002-11-19 05:12:31

by Patrick Mansfield

[permalink] [raw]
Subject: Re: 2.5.48 and SCSI ? (devfs problem!!!)

On Mon, Nov 18, 2002 at 10:49:22PM +0100, Gregoire Favre wrote:
> On Mon, Nov 18, 2002 at 11:33:58PM +0200, Kai Makisara wrote:
> > I had the same problem with sym53c8xxx_2 when devfs was configured into
> > the kernel (but not mounted). Then I made a kernel with devfs disabled and
> > now this boots (and seems to work).
>
> Hello,
>
> well, I "need" devfs and it is mounted... I really don't want to create
> all the devices I use... At least now I know where does the prolem come
> from ;-)
>
> Thank you very much,
>
> Gr?goire

Here's a patch you can try out, I already posted this to linux-scsi
as a fix for /proc/scsi not showing up, I'll make sure James or
someone pushes it to Linus' tree. I don't use devfs.

This is against linus bk but should apply fine against 2.5.48.

-- Patrick Mansfield

===== scsi.c 1.67 vs edited =====
--- 1.67/drivers/scsi/scsi.c Mon Nov 18 08:42:42 2002
+++ edited/scsi.c Mon Nov 18 16:14:23 2002
@@ -2225,6 +2225,8 @@
printk(KERN_ERR "SCSI: can't init sg mempool %s\n", sgp->name);
}

+ scsi_init_procfs();
+ scsi_devfs_handle = devfs_mk_dir(NULL, "scsi", NULL);
scsi_host_init();
scsi_dev_info_list_init(scsi_dev_flags);
bus_register(&scsi_driverfs_bus_type);
@@ -2236,9 +2238,10 @@
{
int i;

+ bus_unregister(&scsi_driverfs_bus_type);
+ scsi_dev_info_list_delete();
devfs_unregister(scsi_devfs_handle);
scsi_exit_procfs();
- scsi_dev_info_list_delete();

for (i = 0; i < SG_MEMPOOL_NR; i++) {
struct scsi_host_sg_pool *sgp = scsi_sg_pools + i;

2002-11-19 07:44:25

by Gregoire Favre

[permalink] [raw]
Subject: Re: 2.5.48 and SCSI ? (devfs problem!!!)

On Mon, Nov 18, 2002 at 09:17:30PM -0800, Patrick Mansfield wrote:

> Here's a patch you can try out, I already posted this to linux-scsi
> as a fix for /proc/scsi not showing up, I'll make sure James or
> someone pushes it to Linus' tree. I don't use devfs.
>
> This is against linus bk but should apply fine against 2.5.48.

I'll try it tonight, thank you very much,

Gr?goire
________________________________________________________________
http://ulima.unil.ch/greg ICQ:16624071 mailto:[email protected]