2002-11-19 18:44:38

by Tom Rini

[permalink] [raw]
Subject: [PATCH][TRIVIAL] Add back in <asm/system.h> and <linux/linkage.h> to <linux/interrupt.h>

The following trivial patch adds back <asm/system.h> and
<linux/kernel.h> to <linux/interrupt.h>. Without it,
<linux/interrupt.h> is relying on <asm/system.h> to be implicitly
included for smb_mb to be defined, and <linux/linkage.h> to be implicitly
included for asmlinkage/FASTCALL/etc.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

===== include/linux/interrupt.h 1.17 vs edited =====
--- 1.17/include/linux/interrupt.h Sun Nov 17 09:23:25 2002
+++ edited/include/linux/interrupt.h Tue Nov 19 11:35:47 2002
@@ -3,11 +3,13 @@
#define _LINUX_INTERRUPT_H

#include <linux/config.h>
+#include <linux/linkage.h>
#include <linux/bitops.h>
#include <asm/atomic.h>
#include <asm/hardirq.h>
#include <asm/ptrace.h>
#include <asm/softirq.h>
+#include <asm/system.h>

struct irqaction {
void (*handler)(int, void *, struct pt_regs *);


2002-11-19 20:14:09

by Pete Zaitcev

[permalink] [raw]
Subject: Re: [PATCH][TRIVIAL] Add back in <asm/system.h> and <linux/linkage.h> to <linux/interrupt.h>

> The following trivial patch adds back <asm/system.h> and
><linux/kernel.h> to <linux/interrupt.h>. Without it,
><linux/interrupt.h> is relying on <asm/system.h> to be implicitly
> included for smb_mb to be defined, and <linux/linkage.h> to be implicitly
> included for asmlinkage/FASTCALL/etc.

Right, RMK posted it a couple of days ago, without linkage.h though.

-- Pete

2002-11-19 23:08:34

by Tom Rini

[permalink] [raw]
Subject: Re: [PATCH][TRIVIAL] Add back in <asm/system.h> and <linux/linkage.h> to <linux/interrupt.h>

On Tue, Nov 19, 2002 at 03:21:08PM -0500, Pete Zaitcev wrote:
> > The following trivial patch adds back <asm/system.h> and
> ><linux/kernel.h> to <linux/interrupt.h>. Without it,
> ><linux/interrupt.h> is relying on <asm/system.h> to be implicitly
> > included for smb_mb to be defined, and <linux/linkage.h> to be implicitly
> > included for asmlinkage/FASTCALL/etc.
>
> Right, RMK posted it a couple of days ago, without linkage.h though.

Then RMK's isn't complete as it needs both. :)

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/