LinuxLists.cc - [PATCH] Make inode_ops->setxattr value parameter const (2.4.x + 2.5.x)

2002-11-20 14:58:48

Subject: [PATCH] Make inode_ops->setxattr value parameter const (2.4.x + 2.5.x)

Hello,

the setxattr inode operation is defined like this in 2.4 and 2.5:

int (*setxattr) (struct dentry *dentry, const char *name,
void *value, size_t size, int flags);

the original type of the value parameter was `const void *'; the const
obviously has been lost at some point. The definition should be:

int (*setxattr) (struct dentry *dentry, const char *name,
const void *value, size_t size, int flags);

Please apply the attached patches.

Thanks,
Andreas.

------------------------------------------------------------------
Andreas Gruenbacher SuSE Linux AG
mailto:[email protected] Deutschherrnstr. 15-19
http://www.suse.de/ D-90429 Nuernberg, Germany

Attachments:

linux-2.5.48-setxattr-const-value.diff (4.63 kB)
linux-2.4.20-rc2-setxattr-const-value.diff (2.69 kB)
Download all attachments

2002-11-20 20:02:02

by Dave Kleikamp

[permalink] [raw]

Subject: Re: [PATCH] Make inode_ops->setxattr value parameter const (2.4.x + 2.5.x)

On Wednesday 20 November 2002 09:05, Andreas Gruenbacher wrote:

> Please apply the attached patches.

Andreas,
Please send the patches separately to Linus and Marcelo. I know Linus
doesn't like patches as attachements, especially when mail contains two
different patches, only one of which he can apply. (Think about saving
the email to a file and running patch against it.)

Otherwise, the patches look good to me.

Thanks,
Shaggy
--
David Kleikamp
IBM Linux Technology Center