So here goes -rc2, fixing the lcall DoS.
Summary of changes from v2.4.20-rc1 to v2.4.20-rc2
============================================
<[email protected]>:
o sock_writable not appropriate for TCP sockets
<[email protected]>:
o fix file system corruption under load
<[email protected]>:
o Use dev_kfree_skb_any not dev_kfree_skb in tg3 net driver function tg3_free_rings.
<[email protected]>:
o Undo latest hid-input fixes: they are broken
o Reverse order of BK config checkout entries
o Changed EXTRAVERSION to -rc2
<[email protected]>:
o Update credits
<[email protected]>:
o Fix carry ripple in 3 and 4 word addition and subtraction macros
<[email protected]>:
o HTREE backwards compatibility patch
Alan Cox <[email protected]>:
o Enable the merged AMD pm driver
Andries E. Brouwer <[email protected]>:
o [TCP] Do not update rcv_nxt until ts_recent is updated
Ben Collins <[email protected]>:
o [TG3]: TG3_HW_STATUS_SIZE should be 0x50 not 0x80
[email protected] <[email protected]>:
o restore framebuffer console after suspend
David S. Miller <[email protected]>:
o [SPARC64]: Translate SO_{SND,RCV}TIMEO socket options
o [SPARC64]: Handle kernel integer divide by zero properly
o [SPARC64]: Check DRM_NEW not DRM in ioctl32.c
o [SPARC64]: Fix accidental clobbering of register on cheetahplus
David S. Miller <[email protected]>:
o Fix tg3 net driver to properly disable interrupts during some TX operations
Edward Peng <[email protected]>:
o sundance net driver updates
Joshua Uziel <[email protected]>:
o [SPARC64]: 0x22/0x10 is Ultra-I/spitfire
Pete Zaitcev <[email protected]>:
o [sparc] Fix off-by-one in s/g handling
Petr Vandrovec <[email protected]>:
o Fix ncpfs file creation issue
Petr Vandrovec <[email protected]>:
o Fix lcall DoS
[email protected] <[email protected]>:
o Fix SX driver detection
Tom Rini <[email protected]>:
o Fix a thinko in arch/ppc/kernel/ppc_ksyms.c
Trond Myklebust <[email protected]>:
o another kmap imbalance in 2.4.x/2.5.x RPC
Vojtech Pavlik <[email protected]>:
o Add vt8235 support
On 15 Nov 02 at 13:10, Marcelo Tosatti wrote:
>
> Petr Vandrovec <[email protected]>:
> o Fix ncpfs file creation issue
>
> Petr Vandrovec <[email protected]>:
> o Fix lcall DoS
Summary generation script needs some tweaking in case sensitivity
area ;-) (and if someone knows how to persuade MSDOS Pegasus Mail
to use username in lowercase, please share this secret with me)
Thanks,
Petr Vandrovec
[email protected]
I got the following error at the final linking of 2.4.20-rc2:
<-- snip -->
...
-o vmlinux
fs/fs.o(.text+0x53bc3): In function `presto_free_cache':
: undefined reference to `presto_dentry_slab'
make: *** [vmlinux] Error 1
<-- snip -->
K S Sreeram <[email protected]> proposed the following patch two
weeks ago:
--- a/fs/intermezzo/dcache.c Mon Oct 21 10:56:57 2002
+++ b/fs/intermezzo/dcache.c Mon Oct 21 10:56:57 2002
@@ -48,7 +48,7 @@
#include <linux/intermezzo_fs.h>
-static kmem_cache_t * presto_dentry_slab;
+kmem_cache_t * presto_dentry_slab;
/* called when a cache lookup succeeds */
static int presto_d_revalidate(struct dentry *de, int flag)
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Fri, 15 Nov 2002 13:10:07 -0200 (BRST),
Marcelo Tosatti <[email protected]> wrote:
>So here goes -rc2, fixing the lcall DoS.
No obvious changes that affect kdb, so unless somebody reports
problems, use kdb-v2.5-2.4.20-rc1 with -rc2.
This patch is obviously correct and has been applied to our
tree. It would be great it was applied to 2.4.20-rc2.
robert
* Adrian Bunk ([email protected]) [021115 15:19]:
> I got the following error at the final linking of 2.4.20-rc2:
>
> <-- snip -->
>
> ...
> -o vmlinux
> fs/fs.o(.text+0x53bc3): In function `presto_free_cache':
> : undefined reference to `presto_dentry_slab'
> make: *** [vmlinux] Error 1
>
> <-- snip -->
>
>
> K S Sreeram <[email protected]> proposed the following patch two
> weeks ago:
>
> --- a/fs/intermezzo/dcache.c Mon Oct 21 10:56:57 2002
> +++ b/fs/intermezzo/dcache.c Mon Oct 21 10:56:57 2002
> @@ -48,7 +48,7 @@
>
> #include <linux/intermezzo_fs.h>
>
> -static kmem_cache_t * presto_dentry_slab;
> +kmem_cache_t * presto_dentry_slab;
>
> /* called when a cache lookup succeeds */
> static int presto_d_revalidate(struct dentry *de, int flag)
>
>
>
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by: To learn the basics of securing
> your web site with SSL, click here to get a FREE TRIAL of a Thawte
> Server Certificate: http://www.gothawte.com/rd524.html
> _______________________________________________
> intermezzo-discuss mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/intermezzo-discuss
Hi Marcelo,
the patch below is still needed to fix a .text.exit error.
Please apply
Adrian
--- linux-2.4.19-full-nohotplug/drivers/scsi/ips.c.old 2002-10-04 18:49:10.000000000 +0200
+++ linux-2.4.19-full-nohotplug/drivers/scsi/ips.c 2002-10-04 18:50:02.000000000 +0200
@@ -305,21 +305,21 @@
name: ips_hot_plug_name,
id_table: ips_pci_table,
probe: ips_insert_device,
- remove: ips_remove_device,
+ remove: __devexit_p(ips_remove_device),
};
struct pci_driver ips_pci_driver_5i = {
name: ips_hot_plug_name,
id_table: ips_pci_table_5i,
probe: ips_insert_device,
- remove: ips_remove_device,
+ remove: __devexit_p(ips_remove_device),
};
struct pci_driver ips_pci_driver_i960 = {
name: ips_hot_plug_name,
id_table: ips_pci_table_i960,
probe: ips_insert_device,
- remove: ips_remove_device,
+ remove: __devexit_p(ips_remove_device),
};
#endif
> > Petr Vandrovec <[email protected]>:
> > o Fix ncpfs file creation issue
> >
> > Petr Vandrovec <[email protected]>:
> > o Fix lcall DoS
>
> Summary generation script needs some tweaking in case sensitivity
> area ;-) (and if someone knows how to persuade MSDOS Pegasus Mail
Fixed in version 0.50 of lk-changelog.pl
(see: http://mandree.home.pages.de/linux/kernel/)
Cheers,
Vita
Hi;
Im pretty sure this is broken, but I dont know exactly
what it is trying to do.
The first snprintf is overwritten regardless-- missing
else block? And its format string should probably be "%4X:%4X",
because whats there wont fit in the buffer.
Then the first 3 chars in the string are filled in
with raw numbers (For my card, non-ascii) and then a single
decimal digit?? (This string is printed out during boot time--
which is how I noticed it because of the 'garbage' chars.)
I dont know what a PnP string is supposed to look like...
Paul
[email protected]
--- linux-2.4.19/drivers/sound/ac97_codec.c 2002-08-03 00:39:44.000000000 +0 000
+++ linux-2.4.20/drivers/sound/ac97_codec.c 2002-11-15 14:56:52.000000000 +0 000
@@ -654,6 +654,27 @@
}
/**
+ * codec_id - Turn id1/id2 into a PnP string
+ * @id1: Vendor ID1
+ * @id2: Vendor ID2
+ * @buf: 10 byte buffer
+ *
+ * Fills buf with a zero terminated PnP ident string for the id1/id2
+ * pair. For convenience the return is the passed in buffer pointer.
+ */
+
+static char *codec_id(u16 id1, u16 id2, char *buf)
+{
+ if(id1&0x8080)
+ snprintf(buf, 10, "%0x4X:%0x4X", id1, id2);
+ buf[0] = (id1 >> 8);
+ buf[1] = (id1 & 0xFF);
+ buf[2] = (id2 >> 8);
+ snprintf(buf+3, 7, "%d", id2&0xFF);
+ return buf;
+}
On Fri, 2002-11-22 at 01:14, Paul wrote:
> Im pretty sure this is broken, but I dont know exactly
> what it is trying to do.
> The first snprintf is overwritten regardless-- missing
> else block? And its format string should probably be "%4X:%4X",
> because whats there wont fit in the buffer.
> Then the first 3 chars in the string are filled in
> with raw numbers (For my card, non-ascii) and then a single
> decimal digit?? (This string is printed out during boot time--
> which is how I noticed it because of the 'garbage' chars.)
> I dont know what a PnP string is supposed to look like...
There is an else missing you are correct
> + if(id1&0x8080)
> + snprintf(buf, 10, "%0x4X:%0x4X", id1, id2);
else
{
> + buf[0] = (id1 >> 8);
> + buf[1] = (id1 & 0xFF);
> + buf[2] = (id2 >> 8);
> + snprintf(buf+3, 7, "%d", id2&0xFF);
}
> + return buf;
> +}
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Alan Cox <[email protected]>, on Fri Nov 22, 2002 [01:57:06 AM] said:
> On Fri, 2002-11-22 at 01:14, Paul wrote:
> > Im pretty sure this is broken, but I dont know exactly
> > what it is trying to do.
> > The first snprintf is overwritten regardless-- missing
> > else block? And its format string should probably be "%4X:%4X",
> > because whats there wont fit in the buffer.
>
> There is an else missing you are correct
>
Hi;
Well, just for the heck of it, here is a patch that
puts the else block in, and fixes the format so that it matches
previous output and fits in the buffer. If the powers that be
wanted "1234:ABCD" instead of "0x1234:0xabcd", then the
format string would be "%04X:%04X" and CODEC_ID_BUFSZ could
go back to 10.
Tested.
Paul
[email protected]