2002-11-24 02:59:13

by Shawn Starr

[permalink] [raw]
Subject: [RFC][TRIVIAL][PATCH][2.5] - Supplimental fix to ACPI_SLEEP & SOFTWARE_SUSPEND compile issue

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch should fix remaining issues regarding compiling ACPI Sleep states with Software suspend.
You need to enable ACPI_SLEEP in config to use software suspend.

The problem is, kbuild doesn't seem to allow this (right?). if ACPI_SLEEP is enabled it will allow you to select
SOFTWARE_SUSPEND but if you uncheck SOFTWARE_SUSPEND it doesn't disable ACPI_SLEEP which
IMHO it should not be because sleeping the system doesn't always mean power off. Standby might be a
sleep state too.

Here's the patch, please comment :)

Shawn.

- From Pavel:

> > Could you make it so that CONFIG_ACPI_SLEEP is not selectable without
> > CONFIG_SOFTWARE_SUSPEND and move CONFIG_SOFTWARE_SUSPEND into "power
> > managment" submenu?
> > Pavel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE94EJQePHb7Xli5GsRAiYgAJ0ZQYfqCSKn+IL6VPeym44mgUbF8gCfW30a
u03BGOgvMjFwIJ5EoF4ByR8=
=kv0+
-----END PGP SIGNATURE-----


Attachments:
(No filename) (1.00 kB)
clearsigned data
2.5.49-acpi-swsusp-2.diff.patch (3.56 kB)
Download all attachments

2002-11-29 03:27:47

by Shawn Starr

[permalink] [raw]
Subject: Re: [RFC][TRIVIAL][PATCH][2.5] - Supplimental fix to ACPI_SLEEP & SOFTWARE_SUSPEND compile issue

This still has problems. Unless kbuild can force an option always on when
another dependency is selected. You will get compile errors.

Solutions?

On November 23, 2002 10:06 pm, Shawn Starr wrote:
> This patch should fix remaining issues regarding compiling ACPI Sleep
> states with Software suspend. You need to enable ACPI_SLEEP in config to
> use software suspend.
>
> The problem is, kbuild doesn't seem to allow this (right?). if ACPI_SLEEP
> is enabled it will allow you to select SOFTWARE_SUSPEND but if you uncheck
> SOFTWARE_SUSPEND it doesn't disable ACPI_SLEEP which IMHO it should not be
> because sleeping the system doesn't always mean power off. Standby might be
> a sleep state too.
>
> Here's the patch, please comment :)
>
> Shawn.
>
> From Pavel:
> > > Could you make it so that CONFIG_ACPI_SLEEP is not selectable without
> > > CONFIG_SOFTWARE_SUSPEND and move CONFIG_SOFTWARE_SUSPEND into "power
> > > managment" submenu?
> > > Pavel