2002-12-03 18:32:57

by Dave Jones

[permalink] [raw]
Subject: [CFT][2.5] AGPGART reworking.

As per private discussion with Linus over the last few days,
I've reworked the AGPGART driver considerably. There's likely
some gotchas left here, so I'd appreciate testers/code-review
of this quite large change (>200KB worth of diff, but several
files get moved about a bit).

- Introduces a new 'agp_register_driver' function, which is used
to seperate the chipset drivers completely from the backend.

- chipset drivers become modules in their own right.
This seems to work when everything is compiled in. Built as modules
is untested yet, but it means right now you have to insmod via-agp.o
or whatever chipset vendor you need before starting X.
agp_try_supported() is now a param to the chipset modules, not the
agpgart.o module.

- i8x0.c & i810.c have become intel-agp.c
CONFIG_AGP_I810 is currently broken, I'll fix this up soon.

- agp.c becomes backend.c

- split out generic routines into generic.c

- version number bump to 1.0
This is a pretty major change IMO, and it's been stuck at 0.99 forever.

- Cast fixes (Alan)

- x86-64 fixes (Andi)

- Add recognition for several new devices.

- list myself as maintainer of 1.0+
Jeff Hartmann hasn't done any considerable work on agpgart since `99
to my knowledge. Attempts to contact him in the past have failed.

You can get this from bk://linux-dj.bkbits.net/agpgart or for the
bk-challenged, you can get the gnu diff at ..
ftp.kernel.org/pub/linux/kernel/people/davej/patches/2.5/2.5.50/agpgart-recore-2.diff.gz

Dave


2002-12-04 08:31:42

by Rudmer van Dijk

[permalink] [raw]
Subject: Re: [CFT][2.5] AGPGART reworking.

On Tuesday 03 December 2002 19:37, [email protected] wrote:
> As per private discussion with Linus over the last few days,
> I've reworked the AGPGART driver considerably. There's likely
> some gotchas left here, so I'd appreciate testers/code-review
> of this quite large change (>200KB worth of diff, but several
> files get moved about a bit).

I'm running it now, see no difference, except for the version in dmesg...

<snip>
Linux agpgart interface v1.0 (c) Dave Jones
agpgart: Detected SiS 735 chipset
agpgart: Maximum main memory to use for agp memory: 203M
spurious 8259A interrupt: IRQ7.
agpgart: AGP aperture is 32M @ 0xd0000000
[drm] AGP 1.0 on SiS @ 0xd0000000 32MB
[drm] Initialized mga 3.1.0 20021029 on minor 0
<snip>

Rudmer