2002-12-06 01:08:30

by Michael

Subject: ide-scsi compile error in 2.5.50-mm1

make -f scripts/Makefile.build obj=drivers/scsi
gcc -Wp,-MD,drivers/scsi/.ide-scsi.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -Iarch/i386/mach-generic -nostdinc -iwithprefix include -DMODULE -DKBUILD_BASENAME=ide_scsi -DKBUILD_MODNAME=ide_scsi -c -o drivers/scsi/ide-scsi.o drivers/scsi/ide-scsi.c
drivers/scsi/ide-scsi.c: In function `should_transform':
drivers/scsi/ide-scsi.c:767: structure has no member named `tag'
make[2]: *** [drivers/scsi/ide-scsi.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

2002-12-06 03:24:17

by Mike Anderson

Subject: Re: ide-scsi compile error in 2.5.50-mm1

Michael [[email protected]] wrote:
> make -f scripts/Makefile.build obj=drivers/scsi
> gcc -Wp,-MD,drivers/scsi/.ide-scsi.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -Iarch/i386/mach-generic -nostdinc -iwithprefix include -DMODULE -DKBUILD_BASENAME=ide_scsi -DKBUILD_MODNAME=ide_scsi -c -o drivers/scsi/ide-scsi.o drivers/scsi/ide-scsi.c
> drivers/scsi/ide-scsi.c: In function `should_transform':
> drivers/scsi/ide-scsi.c:767: structure has no member named `tag'
> make[2]: *** [drivers/scsi/ide-scsi.o] Error 1
> make[1]: *** [drivers/scsi] Error 2
> make: *** [drivers] Error 2

I do not believe we have come to a final patch for this. It was
previously discussed on this thread

http://marc.theaimsgroup.com/?l=linux-kernel&m=103861077118120&w=2

This short term patch from Douglas Gilbert should fix the compile and
restore previous behavior.

-andmike
--
Michael Anderson
[email protected]

--- linux/drivers/scsi/ide-scsi.c 2002-11-23 13:01:23.000000000 +1100
+++ linux/drivers/scsi/ide-scsi.c2550mike 2002-12-01 00:44:26.000000000 +1100
@@ -764,7 +764,7 @@

if (disk) {
struct Scsi_Device_Template **p = disk->private_data;
- if (strcmp((*p)->tag, "sg") == 0)
+ if (strcmp((*p)->scsi_driverfs_driver.name, "sg") == 0)
return test_bit(IDESCSI_SG_TRANSFORM, &scsi->transform);
}
return test_bit(IDESCSI_TRANSFORM, &scsi->transform);