2002-12-10 02:11:16

by Marc-Christian Petersen

[permalink] [raw]
Subject: [PATCH 2.4] IP: disable ECN support by default - Config option

Hi Marcelo,

attached super trivial patch gives us a config option to choose whether we
want ECN disabled per default if selected or not.

consider for inclusion into 2.4.

Has been in WOLK and in Debian kernels for ages.

ciao, Marc


Attachments:
ecn-disable-per-default-config-option.patch (847.00 B)

2002-12-10 02:55:08

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 2.4] IP: disable ECN support by default - Config option


CONFIG_INET_ECN does exactly what you want.

If you turn it on, ECN is on by default.
If you turn it off, ECN is off by default.

The ECN support itself, is always compiled into the
kernel. CONFIG_INET_ECN only determines the initial
setting of the ecn sysctl.

Your patch adds zero functionality and only serves to make
the cofiguration more complicated.

2002-12-10 03:07:02

by Marc-Christian Petersen

[permalink] [raw]
Subject: Re: [PATCH 2.4] IP: disable ECN support by default - Config option

On Tuesday 10 December 2002 04:28, David S. Miller wrote:

Hi David,

> CONFIG_INET_ECN does exactly what you want.
>
> If you turn it on, ECN is on by default.
> If you turn it off, ECN is off by default.

args, you are right. Sorry, my mistake! Maybe I need some sleep, looking twice
it is sooo obvious :)

ciao, Marc

2002-12-10 18:23:52

by Krzysztof Halasa

[permalink] [raw]
Subject: Re: [PATCH 2.4] IP: disable ECN support by default - Config option

Marc-Christian Petersen <[email protected]> writes:

> attached super trivial patch gives us a config option to choose whether we
> want ECN disabled per default if selected or not.

Why do we need that if we can enable/disable ECN at runtime?
--
Krzysztof Halasa
Network Administrator