2002-12-11 22:20:27

by Bob Miller

Subject: [TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c

The function, cs5520_tune_chipset() is declared to return an int.
Added a return statement instead of just falling of off the bottom.

diff -Nru a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c
--- a/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
+++ b/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
@@ -166,6 +166,8 @@
/* ATAPI is harder so leave it for now */
if(!error && drive->media == ide_disk)
error = hwif->ide_dma_on(drive);
+
+ return error;
}

static void cs5520_tune_drive(ide_drive_t *drive, u8 pio)

--
Bob Miller Email: [email protected]
Open Source Development Lab Phone: 503.626.2455 Ext. 17

2002-12-12 00:44:38

by Alan

Subject: Re: [TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c

On Wed, 2002-12-11 at 22:28, Bob Miller wrote:
> The function, cs5520_tune_chipset() is declared to return an int.
> Added a return statement instead of just falling of off the bottom.
>
> diff -Nru a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c
> --- a/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
> +++ b/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
> @@ -166,6 +166,8 @@
> /* ATAPI is harder so leave it for now */
> if(!error && drive->media == ide_disk)
> error = hwif->ide_dma_on(drive);
> +
> + return error;

Eep thats a nasty little bug, lucky my compiler left the error value in
%eax anyway good spotting