2002-12-23 11:50:13

by Tim Pepper

[permalink] [raw]
Subject: ext3/jbd breaks md stacking in 2.4

I recently noticed that ext3/jbd break md stacking by making invalid
assumptions about the buffer head's b_private pointer. There is a
thread discussing this on the LVM mailing list at:

http://linux.msede.com/lvm_mlist/archive/2002/07/0028.html

Searching google and driver source it seems to me that as others have
noticed this they've worked around it by keeping their own pools of
buffer heads instead of simply stacking on the system buffer head.
This strikes me as inefficient and just plain ugly.

The ability to stack b_rdev, b_private and b_end_io is documented kernel
behaviour and therefore shouldn't break in 2.4.

The above link in particular is to a simple patch Andrew Morton suggested.
This patch has been in -ac for quite a while, but is listed as not
forwarded to Marcello (any reason Alan?). Is there any chance of getting
this fix into mainline kernels?

Tim

--
*********************************************************
* tpepper@vato dot org * Venimus, Vidimus, *
* http://www.vato.org/~tpepper * Dolavimus *
*********************************************************