2003-01-08 16:13:20

by Arnd Bergmann

Subject: Re: [IPV6]: Convert mibstats to use kmalloc_percpu

Changeset 1.879.9.7 from [email protected] contains:

> @@ -765,6 +847,7 @@
> #ifdef CONFIG_SYSCTL
> ipv6_sysctl_unregister();
> #endif
> + cleanup_ipv6_mibs();
> }
> module_exit(inet6_exit);
> #endif /* MODULE */

This does not work when cleanup_ipv6_mibs() is marked __exit,
the fix below is needed to build a kernel with ipv6.

===== net/ipv6/af_inet6.c 1.18 vs edited =====
--- 1.18/net/ipv6/af_inet6.c Tue Jan 7 11:19:42 2003
+++ edited/net/ipv6/af_inet6.c Wed Jan 8 17:08:52 2003
@@ -684,7 +684,7 @@

}

-static void __exit cleanup_ipv6_mibs(void)
+static void cleanup_ipv6_mibs(void)
{
kfree_percpu(ipv6_statistics[0]);
kfree_percpu(ipv6_statistics[1]);

2003-01-09 14:07:39

by Ravikiran G Thirumalai

Subject: Re: [IPV6]: Convert mibstats to use kmalloc_percpu

> This does not work when cleanup_ipv6_mibs() is marked __exit,
> the fix below is needed to build a kernel with ipv6.

Yes, it should not have been marked __exit.
Thanks for the patch
Dave, Plase apply.

Thanks,
Kiran