2003-01-09 09:42:03

by Miles Bader

Subject: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty

Since these are just symbols in the module object, they need symbol name
munging to find the symbol from the parameter name.

[I guess using the stack is bad in general, but parameter names should be
very short, and hey if they're obsolete, it seems pointless to spend
much effort.]

diff -ruN -X../cludes linux-2.5.55-moo.orig/kernel/module.c linux-2.5.55-moo/kernel/module.c
--- linux-2.5.55-moo.orig/kernel/module.c 2003-01-09 13:44:25.000000000 +0900
+++ linux-2.5.55-moo/kernel/module.c 2003-01-09 14:07:36.000000000 +0900
@@ -685,13 +685,18 @@
num, obsparm[i].name, obsparm[i].type);

for (i = 0; i < num; i++) {
+ char sym_name[strlen (obsparm[i].name) + 2];
+
+ strcpy (sym_name, MODULE_SYMBOL_PREFIX);
+ strcat (sym_name, obsparm[i].name);
+
kp[i].name = obsparm[i].name;
kp[i].perm = 000;
kp[i].set = set_obsolete;
kp[i].get = NULL;
obsparm[i].addr
= (void *)find_local_symbol(sechdrs, symindex, strtab,
- obsparm[i].name);
+ sym_name);
if (!obsparm[i].addr) {
printk("%s: falsely claims to have parameter %s\n",
name, obsparm[i].name);

2003-01-10 09:02:37

by Rusty Russell

Subject: Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty

In message <[email protected]> you write:
> Since these are just symbols in the module object, they need symbol name
> munging to find the symbol from the parameter name.

I've got this one already pending (I managed to pick up mail once
while travelling to a funeral, but generally I've been offline for 4
days).

Thanks!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.