2003-01-09 21:50:41

by Petr Vandrovec

[permalink] [raw]
Subject: [PATCH] kallsyms prints wrong symbol names

Hi Linus,

Since stem compression arrived to kallsyms table, we are printing
name of symbol BEFORE one we want to print (and empty string for
first symbol) because of we return buffer with copy of last name
we skipped instead of 'name' variable as we did before. So one more
pass through loop is required.

Without this patch my stack traces were really strange...

Thanks,
Petr Vandrovec
[email protected]



--- linux-2.5.55/kernel/kallsyms.c 2003-01-09 22:47:40.000000000 +0100
+++ linux-2.5.55/kernel/kallsyms.c 2003-01-09 22:38:01.000000000 +0100
@@ -46,7 +46,7 @@
}

/* Grab name */
- for (i = 0; i < best; i++) {
+ for (i = 0; i < best + 1; i++) {
unsigned prefix = *name++;
strncpy(namebuf + prefix, name, 127 - prefix);
name += strlen(name) + 1;