2003-01-10 22:08:18

by Petr Vandrovec

Subject: [PATCH] module-init-tools-0.9.7, depmod and GPL-only symbols

Hi Rusty,
I finally got 2.5.56 running with configuration I always used (== almost
everything modular), and I found that module-init-tools-0.9.7 has small
problem with GPL-only symbols: depmod ignores them :-(

As I did not notice any newer version, please apply patch below if you
did not do something simillar already.

Of course you can create better solution, which will actually check
license and so on, but I just decided to leave this task on kernel, as
I believe that we do not want such code duplication between kernel and
module-init-tools.
Thanks,
Petr Vandrovec


diff -ur module-init-tools-0.9.7.src/moduleops_core.c module-init-tools-0.9.7/moduleops_core.c
--- module-init-tools-0.9.7.src/moduleops_core.c 2002-12-26 07:04:42.000000000 +0100
+++ module-init-tools-0.9.7/moduleops_core.c 2003-01-10 23:08:47.000000000 +0100
@@ -30,6 +30,9 @@
ksyms = PERBIT(load_section)(module->mmap, "__ksymtab", &size);
for (i = 0; i < size / sizeof(struct PERBIT(kernel_symbol)); i++)
add_symbol(ksyms[i].name, module);
+ ksyms = PERBIT(load_section)(module->mmap, "__gpl_ksymtab", &size);
+ for (i = 0; i < size / sizeof(struct PERBIT(kernel_symbol)); i++)
+ add_symbol(ksyms[i].name, module);
}

/* Calculate the dependencies for this module */

2003-01-11 09:54:41

by Rusty Russell

Subject: Re: [PATCH] module-init-tools-0.9.7, depmod and GPL-only symbols

In message <20030110221649.GA5371@vana> you write:
> Hi Rusty,
> I finally got 2.5.56 running with configuration I always used (== almost
> everything modular), and I found that module-init-tools-0.9.7 has small
> problem with GPL-only symbols: depmod ignores them :-(
>
> As I did not notice any newer version, please apply patch below if you
> did not do something simillar already.

Yep, included; my bad. Also did the same thing for System.map
parsing.

I'll probably release a new version today.

Thanks!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.